| Message ID | 1442579507-20314-1-git-send-email-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Srini, On Fri, Sep 18, 2015 at 5:31 AM, Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > This patch adds missing 2pin uart pinctrl property to gsbi7 uart on > IFC6410. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> kernelci.org found some new boot failures in -next on 8064[1]. I bisected it down to this patch, which landed in linux next in the form of commit d3a578ed4310 ARM: dts: ifc6410: Add missing pinctrl to gsbi7 uart. Kevin [1] http://kernelci.org/boot/qcom-apq8064-ifc6410/job/next/kernel/next-20150925/defconfig/multi_v7_defconfig/lab/lab-khilman/?_id=5605083c59b51466d26c3250
Hi Kevin, Thanks for reporting this issue. On 25/09/15 19:54, Kevin Hilman wrote: > Hi Srini, > > On Fri, Sep 18, 2015 at 5:31 AM, Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: >> This patch adds missing 2pin uart pinctrl property to gsbi7 uart on >> IFC6410. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > kernelci.org found some new boot failures in -next on 8064[1]. I > bisected it down to this patch, which landed in linux next in the form > of commit d3a578ed4310 ARM: dts: ifc6410: Add missing pinctrl to gsbi7 > uart. > This issue is due to missing CONFIG_PINCTRL_APQ8064 Kconfig in multi_v7_defconfig. In my tests I always enable this config which is why I could not spot this breakage. This patch as it is the right thing to do however we need a fix to multi_v7_defconfig. I will send a patch for multi_v7_defconfig to address this and add few more missing configs too. thanks, --srini > Kevin > > [1] http://kernelci.org/boot/qcom-apq8064-ifc6410/job/next/kernel/next-20150925/defconfig/multi_v7_defconfig/lab/lab-khilman/?_id=5605083c59b51466d26c3250 >
diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts index 56eaf5a..c1d5bd7 100644 --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts @@ -154,6 +154,8 @@ qcom,mode = <GSBI_PROT_I2C_UART>; serial@16640000 { status = "ok"; + pinctrl-names = "default"; + pinctrl-0 = <&gsbi7_uart_2pins>; }; };
This patch adds missing 2pin uart pinctrl property to gsbi7 uart on IFC6410. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 2 ++ 1 file changed, 2 insertions(+)