diff mbox

crypto: blkcipher and ablkcipher should it be static

Message ID d1ae7b48c3c85404ceec994ab2762e947554e9eb.1443365135.git.geliangtang@163.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show

Commit Message

Geliang Tang Sept. 27, 2015, 2:47 p.m. UTC 
Fixes the following sparse warnings:

 crypto/skcipher.c:94:5:
 warning: symbol 'crypto_init_skcipher_ops_blkcipher'
 was not declared. Should it be static?

 crypto/skcipher.c:185:5:
 warning: symbol 'crypto_init_skcipher_ops_ablkcipher'
 was not declared. Should it be static?

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 crypto/skcipher.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Herbert Xu Oct. 1, 2015, 2:01 p.m. UTC | #1 
On Sun, Sep 27, 2015 at 10:47:05PM +0800, Geliang Tang wrote:
> Fixes the following sparse warnings:
> 
>  crypto/skcipher.c:94:5:
>  warning: symbol 'crypto_init_skcipher_ops_blkcipher'
>  was not declared. Should it be static?
> 
>  crypto/skcipher.c:185:5:
>  warning: symbol 'crypto_init_skcipher_ops_ablkcipher'
>  was not declared. Should it be static?
> 
> Signed-off-by: Geliang Tang <geliangtang@163.com>

Patch applied.  Thanks!
diff mbox

Patch

diff --git a/crypto/skcipher.c b/crypto/skcipher.c
index dd5fc1b..7591928 100644
--- a/crypto/skcipher.c
+++ b/crypto/skcipher.c
@@ -91,7 +91,7 @@  static void crypto_exit_skcipher_ops_blkcipher(struct crypto_tfm *tfm)
 	crypto_free_blkcipher(*ctx);
 }
 
-int crypto_init_skcipher_ops_blkcipher(struct crypto_tfm *tfm)
+static int crypto_init_skcipher_ops_blkcipher(struct crypto_tfm *tfm)
 {
 	struct crypto_alg *calg = tfm->__crt_alg;
 	struct crypto_skcipher *skcipher = __crypto_skcipher_cast(tfm);
@@ -182,7 +182,7 @@  static void crypto_exit_skcipher_ops_ablkcipher(struct crypto_tfm *tfm)
 	crypto_free_ablkcipher(*ctx);
 }
 
-int crypto_init_skcipher_ops_ablkcipher(struct crypto_tfm *tfm)
+static int crypto_init_skcipher_ops_ablkcipher(struct crypto_tfm *tfm)
 {
 	struct crypto_alg *calg = tfm->__crt_alg;
 	struct crypto_skcipher *skcipher = __crypto_skcipher_cast(tfm);