| Message ID | 1444699628-3774-3-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Krzysztof, On Tue, Oct 13, 2015 at 3:27 AM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > Enable support for Maxim 8997 Multi Function Device present on Trats and > Origen boards by toggling on drivers: main MFD, charger, haptic motor, > regulator, LED and RTC. > > This allows to test and usage of these boards with multi_v7 config. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- [snip] > CONFIG_MFD_MAX77686=y > CONFIG_MFD_MAX77693=y > CONFIG_MFD_MAX8907=y > +CONFIG_MFD_MAX8997=y Only slightly related with your patch but some of the MFD driver for PMICs used in Exynos boards (like MAX77686) have a tristate Kconfig symbol while others like this one have a boolean. Do you know if there are any restrictions w.r.t build this as module or is just an arbitrary decision? I'm asking since probably we should either allow this to build as a module or convert the others to boolean. Patch looks good to me: Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
W dniu 13.10.2015 o 17:36, Javier Martinez Canillas pisze: > Hello Krzysztof, > > On Tue, Oct 13, 2015 at 3:27 AM, Krzysztof Kozlowski > <k.kozlowski@samsung.com> wrote: >> Enable support for Maxim 8997 Multi Function Device present on Trats and >> Origen boards by toggling on drivers: main MFD, charger, haptic motor, >> regulator, LED and RTC. >> >> This allows to test and usage of these boards with multi_v7 config. >> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> --- > > [snip] > >> CONFIG_MFD_MAX77686=y >> CONFIG_MFD_MAX77693=y >> CONFIG_MFD_MAX8907=y >> +CONFIG_MFD_MAX8997=y > > Only slightly related with your patch but some of the MFD driver for > PMICs used in Exynos boards (like MAX77686) have a tristate Kconfig > symbol while others like this one have a boolean. Do you know if there > are any restrictions w.r.t build this as module or is just an > arbitrary decision? I'm asking since probably we should either allow > this to build as a module or convert the others to boolean. First, thanks for reviewing the patches. As for the question, I wasn't involved in development of these older drivers for older boards. I don't know their internals. AFAIK there were no specific restrictions, except the usual: 1. Not all other drivers using resources provided by these, took the reference to given resource (e.g. get regulator). 2. Not all consumer drivers supported deferred probe for given resource (e.g. regulator, clock), see: "regulators: max77693: register driver earlier to avoid deferred probe". In general USB gadget subsystem has this issue. Actually the mentioned max77693 regulator driver should be changed from tristate to built-in because of this. I don't remember any other important issues so if you fix 1 and 2 then this can be probably safely switched to modules. Of course after testing. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Krzysztof, On 10/13/2015 03:18 PM, Krzysztof Kozlowski wrote: > W dniu 13.10.2015 o 17:36, Javier Martinez Canillas pisze: >> Hello Krzysztof, >> >> On Tue, Oct 13, 2015 at 3:27 AM, Krzysztof Kozlowski >> <k.kozlowski@samsung.com> wrote: >>> Enable support for Maxim 8997 Multi Function Device present on Trats and >>> Origen boards by toggling on drivers: main MFD, charger, haptic motor, >>> regulator, LED and RTC. >>> >>> This allows to test and usage of these boards with multi_v7 config. >>> >>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>> --- >> >> [snip] >> >>> CONFIG_MFD_MAX77686=y >>> CONFIG_MFD_MAX77693=y >>> CONFIG_MFD_MAX8907=y >>> +CONFIG_MFD_MAX8997=y >> >> Only slightly related with your patch but some of the MFD driver for >> PMICs used in Exynos boards (like MAX77686) have a tristate Kconfig >> symbol while others like this one have a boolean. Do you know if there >> are any restrictions w.r.t build this as module or is just an >> arbitrary decision? I'm asking since probably we should either allow >> this to build as a module or convert the others to boolean. > > First, thanks for reviewing the patches. > You are welcome. > As for the question, I wasn't involved in development of these older > drivers for older boards. I don't know their internals. AFAIK there were > no specific restrictions, except the usual: > > 1. Not all other drivers using resources provided by these, took the > reference to given resource (e.g. get regulator). > > 2. Not all consumer drivers supported deferred probe for given resource > (e.g. regulator, clock), see: "regulators: max77693: register driver > earlier to avoid deferred probe". In general USB gadget subsystem has > this issue. Actually the mentioned max77693 regulator driver should be > changed from tristate to built-in because of this. > > I don't remember any other important issues so if you fix 1 and 2 then > this can be probably safely switched to modules. Of course after testing. > Thanks for the explanation. I neither plan to fix these issues nor changing these symbols to tristate since I don't have access to the hardware to test. I asked mostly because I was curious and to know if I should change the MFD drivers to boolean for the PMIC present in boards I have access, to make it consistent. But as you said is the other way around, that it would be good to allow these drivers to be built as a module. > Best regards, > Krzysztof > > -- Best regards,
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 05948da5bb69..0b2b474649a2 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -248,6 +248,7 @@ CONFIG_TOUCHSCREEN_ST1232=m CONFIG_TOUCHSCREEN_STMPE=y CONFIG_TOUCHSCREEN_SUN4I=y CONFIG_INPUT_MISC=y +CONFIG_INPUT_MAX8997_HAPTIC=m CONFIG_INPUT_MPU3050=y CONFIG_INPUT_AXP20X_PEK=y CONFIG_INPUT_ADXL34X=m @@ -359,6 +360,7 @@ CONFIG_BATTERY_MAX17040=m CONFIG_BATTERY_MAX17042=m CONFIG_CHARGER_MAX14577=m CONFIG_CHARGER_MAX77693=m +CONFIG_CHARGER_MAX8997=m CONFIG_CHARGER_TPS65090=y CONFIG_POWER_RESET_AS3722=y CONFIG_POWER_RESET_GPIO=y @@ -397,6 +399,7 @@ CONFIG_MFD_MAX14577=y CONFIG_MFD_MAX77686=y CONFIG_MFD_MAX77693=y CONFIG_MFD_MAX8907=y +CONFIG_MFD_MAX8997=y CONFIG_MFD_RK808=y CONFIG_MFD_PM8921_CORE=y CONFIG_MFD_QCOM_RPM=y @@ -421,6 +424,7 @@ CONFIG_POWER_RESET_SYSCON=y CONFIG_REGULATOR_MAX14577=m CONFIG_REGULATOR_MAX8907=y CONFIG_REGULATOR_MAX8973=y +CONFIG_REGULATOR_MAX8997=m CONFIG_REGULATOR_MAX77686=y CONFIG_REGULATOR_MAX77693=m CONFIG_REGULATOR_MAX77802=m @@ -568,6 +572,7 @@ CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=y CONFIG_LEDS_GPIO=y CONFIG_LEDS_PWM=y +CONFIG_LEDS_MAX8997=m CONFIG_LEDS_TRIGGERS=y CONFIG_LEDS_TRIGGER_TIMER=y CONFIG_LEDS_TRIGGER_ONESHOT=y @@ -587,6 +592,7 @@ CONFIG_RTC_DRV_AS3722=y CONFIG_RTC_DRV_DS1307=y CONFIG_RTC_DRV_HYM8563=m CONFIG_RTC_DRV_MAX8907=y +CONFIG_RTC_DRV_MAX8997=m CONFIG_RTC_DRV_MAX77686=y CONFIG_RTC_DRV_RK808=m CONFIG_RTC_DRV_MAX77802=m
Enable support for Maxim 8997 Multi Function Device present on Trats and Origen boards by toggling on drivers: main MFD, charger, haptic motor, regulator, LED and RTC. This allows to test and usage of these boards with multi_v7 config. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- arch/arm/configs/multi_v7_defconfig | 6 ++++++ 1 file changed, 6 insertions(+)