| Message ID | 20151013070818.GB31537@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 931dfa6931448ccfd12d4ccd8d1d9289ceb92439 |
| Headers | show |
On Tue, Oct 13, 2015 at 10:08:18AM +0300, Dan Carpenter wrote: > We try to check that "deemph" is zero or one, but because of an > underflow bug, it can also be negative. It's fine, negative values are > handled as non-zero. But it's messy and static checkers complain so > let's fix it. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles
diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c index b783743..2aa23f1 100644 --- a/sound/soc/codecs/wm8904.c +++ b/sound/soc/codecs/wm8904.c @@ -534,7 +534,7 @@ static int wm8904_put_deemph(struct snd_kcontrol *kcontrol, { struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol); struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec); - int deemph = ucontrol->value.integer.value[0]; + unsigned int deemph = ucontrol->value.integer.value[0]; if (deemph > 1) return -EINVAL;
We try to check that "deemph" is zero or one, but because of an underflow bug, it can also be negative. It's fine, negative values are handled as non-zero. But it's messy and static checkers complain so let's fix it. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>