| Message ID | 20151013070857.GC31537@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 523bade22428d4c6742dd7bfb4c0259a23bb9ec3 |
| Headers | show |
On Tue, Oct 13, 2015 at 10:08:57AM +0300, Dan Carpenter wrote: > The code tries to verify that "deemph" is zero or one, but it fails to > account for that it can be negative. It's harmless because negatives > are treated the same as one, but we should fix it just to silence the > static checker warning. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c index ace8645..07cf1bd 100644 --- a/sound/soc/codecs/wm8731.c +++ b/sound/soc/codecs/wm8731.c @@ -132,7 +132,7 @@ static int wm8731_put_deemph(struct snd_kcontrol *kcontrol, { struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol); struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(codec); - int deemph = ucontrol->value.integer.value[0]; + unsigned int deemph = ucontrol->value.integer.value[0]; int ret = 0; if (deemph > 1)
The code tries to verify that "deemph" is zero or one, but it fails to account for that it can be negative. It's harmless because negatives are treated the same as one, but we should fix it just to silence the static checker warning. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>