diff mbox

ASoC: wm8960: harmless underflow in wm8960_put_deemph()

Message ID 20151013070919.GD31537@mwanda (mailing list archive)
State Accepted
Commit c1fe81f2cd30c18d7df444697bac8051fdf2aee6
Headers show

Commit Message

Dan Carpenter Oct. 13, 2015, 7:09 a.m. UTC 
We should only accept "deemph" values of zero and one, but by mistake we
accept negatives as well.  It's harmless but let's clean it up anyway.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Charles Keepax Oct. 13, 2015, 12:28 p.m. UTC | #1 
On Tue, Oct 13, 2015 at 10:09:19AM +0300, Dan Carpenter wrote:
> We should only accept "deemph" values of zero and one, but by mistake we
> accept negatives as well.  It's harmless but let's clean it up anyway.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles
diff mbox

Patch

diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index e3b7d0c..dc47c2f 100644
--- a/sound/soc/codecs/wm8960.c
+++ b/sound/soc/codecs/wm8960.c
@@ -201,7 +201,7 @@  static int wm8960_put_deemph(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
 	struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
-	int deemph = ucontrol->value.integer.value[0];
+	unsigned int deemph = ucontrol->value.integer.value[0];
 
 	if (deemph > 1)
 		return -EINVAL;