diff mbox

ASoC: wm8903: harmless underflow in wm8903_put_deemph()

Message ID 20151013071018.GF31537@mwanda (mailing list archive)
State Accepted
Commit 4d0197a5cad29ee58593eceac85cbb712430cd89
Headers show

Commit Message

Dan Carpenter Oct. 13, 2015, 7:10 a.m. UTC 
Valid values for "deemph" are zero and one, but we accidentally allow
negative values as well.  It's harmless, but static checkers complain
and we may as well clean it up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Charles Keepax Oct. 13, 2015, 12:28 p.m. UTC | #1 
On Tue, Oct 13, 2015 at 10:10:18AM +0300, Dan Carpenter wrote:
> Valid values for "deemph" are zero and one, but we accidentally allow
> negative values as well.  It's harmless, but static checkers complain
> and we may as well clean it up.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles
diff mbox

Patch

diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c
index b011253..e4cc41e 100644
--- a/sound/soc/codecs/wm8903.c
+++ b/sound/soc/codecs/wm8903.c
@@ -452,7 +452,7 @@  static int wm8903_put_deemph(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
 	struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
-	int deemph = ucontrol->value.integer.value[0];
+	unsigned int deemph = ucontrol->value.integer.value[0];
 	int ret = 0;
 
 	if (deemph > 1)