| Message ID | 1444838695-7182-1-git-send-email-daniel.thompson@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
On Wed, Oct 14, 2015 at 05:04:55PM +0100, Daniel Thompson wrote: > Commit c6a97c42e399 ("hwrng: stm32 - add support for STM32 HW RNG") > was inadequately tested (actually it was tested quite hard so > incompetent would be a better description that inadequate) and does > not compile on platforms with CONFIG_PM set. > > Fix this. > > Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> Patch applied. Thanks!
diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c index 7fa3656a5fc5..92a810648bd0 100644 --- a/drivers/char/hw_random/stm32-rng.c +++ b/drivers/char/hw_random/stm32-rng.c @@ -160,7 +160,7 @@ static int stm32_rng_probe(struct platform_device *ofdev) #ifdef CONFIG_PM static int stm32_rng_runtime_suspend(struct device *dev) { - struct stm32_rng_private *priv = dev_get_drvdata(pdev); + struct stm32_rng_private *priv = dev_get_drvdata(dev); stm32_rng_cleanup(&priv->rng); @@ -169,7 +169,7 @@ static int stm32_rng_runtime_suspend(struct device *dev) static int stm32_rng_runtime_resume(struct device *dev) { - struct stm32_rng_private *priv = dev_get_drvdata(pdev); + struct stm32_rng_private *priv = dev_get_drvdata(dev); return stm32_rng_init(&priv->rng); }
Commit c6a97c42e399 ("hwrng: stm32 - add support for STM32 HW RNG") was inadequately tested (actually it was tested quite hard so incompetent would be a better description that inadequate) and does not compile on platforms with CONFIG_PM set. Fix this. Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> --- Notes: Herbert: This is the diff between v2 and v3 of my STM32 HW RNG patch. This is partly reassurance of what has changed and also "just in case" you prefer to simply fix the problem. drivers/char/hw_random/stm32-rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html