| Message ID | 1444906530-25048-4-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 15 October 2015 at 12:55, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > The Exynos5250 Snow Chromebooks have a Marvell WiFi SDIO chip which > can't neither be removed nor be detected. But the node isn't marked > as non-removable and instead has the broken-cd DT property. > > This causes the device to be removed when the system enters into a > suspend state and the following warnings is shown after a resume: > > [ 181.944636] mmc2: error -2 during resume (card was removed?) Hi Javier, isn't wifi on snow on mmc_3? With your patch, I don't see any change, but if I do it on mmc_3 instead, the machine fails to resume. Will try to get more info. Regards, Tomeu > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi > index 0a7f408824d8..bf27957fd660 100644 > --- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi > +++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi > @@ -520,7 +520,7 @@ > &mmc_0 { > status = "okay"; > num-slots = <1>; > - broken-cd; > + non-removable; > card-detect-delay = <200>; > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <2 3>; > -- > 2.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Tomeu, On 10/15/2015 02:30 PM, Tomeu Vizoso wrote: > On 15 October 2015 at 12:55, Javier Martinez Canillas > <javier@osg.samsung.com> wrote: >> The Exynos5250 Snow Chromebooks have a Marvell WiFi SDIO chip which >> can't neither be removed nor be detected. But the node isn't marked >> as non-removable and instead has the broken-cd DT property. >> >> This causes the device to be removed when the system enters into a >> suspend state and the following warnings is shown after a resume: >> >> [ 181.944636] mmc2: error -2 during resume (card was removed?) > > Hi Javier, > > isn't wifi on snow on mmc_3? > Sigh, you are correct. It seems I have a really bad day and missed. I got confused though because the node for mmc_0 (eMMC) in Snow also has a broken-cd property instead of non-removable. I'll add another patch to the series changing that. I also noticed that the mmc_0 (eMMC) node in Peach boards have both non-removable and broken-cd which doesn't make sense and the MMC DT binding is clear that the options are mutually exclusive. Seems to be copy & paste error from the vendor tree since the downstream DTS also have both properties in the nodes. So I'll also add patches to remove the broken-cd from these nodes. > With your patch, I don't see any change, but if I do it on mmc_3 > instead, the machine fails to resume. Will try to get more info. > Yes, I wouldn't expect any changes since the patch is marking the eMMC as non-removable but I wonder why is causing a fail to resume. Are you sure the system is resuming without $SUBJECT? You mentioned in IRC that S2R was broken for Snow in linux-next. > Regards, > > Tomeu > Best regards,
diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi index 0a7f408824d8..bf27957fd660 100644 --- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi +++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi @@ -520,7 +520,7 @@ &mmc_0 { status = "okay"; num-slots = <1>; - broken-cd; + non-removable; card-detect-delay = <200>; samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <2 3>;
The Exynos5250 Snow Chromebooks have a Marvell WiFi SDIO chip which can't neither be removed nor be detected. But the node isn't marked as non-removable and instead has the broken-cd DT property. This causes the device to be removed when the system enters into a suspend state and the following warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- arch/arm/boot/dts/exynos5250-snow-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)