| Message ID | 20151019030253.6274.46547.sendpatchset@little-apple (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Magnus, Thank you for the patch. On Monday 19 October 2015 12:02:53 Magnus Damm wrote: > From: Magnus Damm <damm+renesas@opensource.se> > > Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE > nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get > rid of the dependency. > > Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: > # CONFIG_ARM_LPAE is not set The driver only supports the 40-bits page table format for now, hence the dependency on LPAE, but it indeed seems that the dependency is bogus. As long as the 8 MSBs of the translated address are all 0 I assume the output 40-bit address is usable on a 32-bit physical address system. How have you tested the patch ? > Signed-off-by: Magnus Damm <damm+renesas@opensource.se> > --- > > drivers/iommu/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > --- 0001/drivers/iommu/Kconfig > +++ work/drivers/iommu/Kconfig 2015-10-18 14:58:09.080513000 +0900 > @@ -324,7 +324,6 @@ config SHMOBILE_IOMMU_L1SIZE > > config IPMMU_VMSA > bool "Renesas VMSA-compatible IPMMU" > - depends on ARM_LPAE > depends on ARCH_SHMOBILE || COMPILE_TEST > select IOMMU_API > select IOMMU_IO_PGTABLE_LPAE
Hi Laurent, On Mon, Oct 19, 2015 at 3:42 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi Magnus, > > Thank you for the patch. > > On Monday 19 October 2015 12:02:53 Magnus Damm wrote: >> From: Magnus Damm <damm+renesas@opensource.se> >> >> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE >> nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get >> rid of the dependency. >> >> Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: >> # CONFIG_ARM_LPAE is not set > > The driver only supports the 40-bits page table format for now, hence the > dependency on LPAE, but it indeed seems that the dependency is bogus. As long > as the 8 MSBs of the translated address are all 0 I assume the output 40-bit > address is usable on a 32-bit physical address system. > > How have you tested the patch ? Modetest with local IPMMUMX enablement on r8a7794 ALT. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Magnus, On Tuesday 20 October 2015 17:54:59 Magnus Damm wrote: > On Mon, Oct 19, 2015 at 3:42 PM, Laurent Pinchart wrote: > > On Monday 19 October 2015 12:02:53 Magnus Damm wrote: > >> From: Magnus Damm <damm+renesas@opensource.se> > >> > >> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE > >> nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get > >> rid of the dependency. > >> > >> Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: > >> # CONFIG_ARM_LPAE is not set > > > > The driver only supports the 40-bits page table format for now, hence the > > dependency on LPAE, but it indeed seems that the dependency is bogus. As > > long as the 8 MSBs of the translated address are all 0 I assume the > > output 40-bit address is usable on a 32-bit physical address system. > > > > How have you tested the patch ? > > Modetest with local IPMMUMX enablement on r8a7794 ALT. Then, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
On Mon, Oct 19, 2015 at 12:02:53PM +0900, Magnus Damm wrote: > From: Magnus Damm <damm+renesas@opensource.se> > > Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE > nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get > rid of the dependency. > > Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: > # CONFIG_ARM_LPAE is not set > > Signed-off-by: Magnus Damm <damm+renesas@opensource.se> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- 0001/drivers/iommu/Kconfig +++ work/drivers/iommu/Kconfig 2015-10-18 14:58:09.080513000 +0900 @@ -324,7 +324,6 @@ config SHMOBILE_IOMMU_L1SIZE config IPMMU_VMSA bool "Renesas VMSA-compatible IPMMU" - depends on ARM_LPAE depends on ARCH_SHMOBILE || COMPILE_TEST select IOMMU_API select IOMMU_IO_PGTABLE_LPAE