| Message ID | 1445874072-25909-18-git-send-email-ygardi@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/26/2015 08:41 AM, Yaniv Gardi wrote: > Tnis patch fixes the following compilation warnings: > ...ufs-qcom.c:1201:40: > warning: incorrect type in argument 1 (different address spaces) > ...ufs-qcom.c:1201:40: > expected void const *ptr > ...ufs-qcom.c:1201:40: > got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio > ...ufs-qcom.c:1207:53: > warning: incorrect type in argument 1 (different address spaces) > ...ufs-qcom.c:1207:53: > expected void const *ptr > ...ufs-qcom.c:1207:53: > got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio > > Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org> > > --- What version of sparse do you use? You shouldn't need to do this. > drivers/scsi/ufs/ufs-qcom.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index 72b0ef7..b57f88a 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -1226,11 +1226,12 @@ static int ufs_qcom_init(struct ufs_hba *hba) > if (res) { > host->dev_ref_clk_ctrl_mmio = > devm_ioremap_resource(dev, res); > - if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) { > - dev_warn(dev, > - "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n", > + if (IS_ERR((__force void const *) > + host->dev_ref_clk_ctrl_mmio)) { > + dev_warn(dev, "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n", > __func__, > - PTR_ERR(host->dev_ref_clk_ctrl_mmio)); > + PTR_ERR((__force void const *) > + host->dev_ref_clk_ctrl_mmio)); > host->dev_ref_clk_ctrl_mmio = NULL; > } > host->dev_ref_clk_en_mask = BIT(5);
> On 10/26/2015 08:41 AM, Yaniv Gardi wrote: >> Tnis patch fixes the following compilation warnings: >> ...ufs-qcom.c:1201:40: >> warning: incorrect type in argument 1 (different address spaces) >> ...ufs-qcom.c:1201:40: >> expected void const *ptr >> ...ufs-qcom.c:1201:40: >> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio >> ...ufs-qcom.c:1207:53: >> warning: incorrect type in argument 1 (different address spaces) >> ...ufs-qcom.c:1207:53: >> expected void const *ptr >> ...ufs-qcom.c:1207:53: >> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio >> >> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org> >> >> --- > > What version of sparse do you use? You shouldn't need to do this. > i just updated my sparse to the newest - so i'm using sparse 0.4.4 and the command i use is: make ARCH=arm C=1 CF="-Wsparse-all" and i still get all the warnings. with my patch, the are no warnings. >> drivers/scsi/ufs/ufs-qcom.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c >> index 72b0ef7..b57f88a 100644 >> --- a/drivers/scsi/ufs/ufs-qcom.c >> +++ b/drivers/scsi/ufs/ufs-qcom.c >> @@ -1226,11 +1226,12 @@ static int ufs_qcom_init(struct ufs_hba *hba) >> if (res) { >> host->dev_ref_clk_ctrl_mmio = >> devm_ioremap_resource(dev, res); >> - if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) { >> - dev_warn(dev, >> - "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n", >> + if (IS_ERR((__force void const *) >> + host->dev_ref_clk_ctrl_mmio)) { >> + dev_warn(dev, "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n", >> __func__, >> - PTR_ERR(host->dev_ref_clk_ctrl_mmio)); >> + PTR_ERR((__force void const *) >> + host->dev_ref_clk_ctrl_mmio)); >> host->dev_ref_clk_ctrl_mmio = NULL; >> } >> host->dev_ref_clk_en_mask = BIT(5); > > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/27/2015 03:10 AM, ygardi@codeaurora.org wrote: >> On 10/26/2015 08:41 AM, Yaniv Gardi wrote: >>> Tnis patch fixes the following compilation warnings: >>> ...ufs-qcom.c:1201:40: >>> warning: incorrect type in argument 1 (different address spaces) >>> ...ufs-qcom.c:1201:40: >>> expected void const *ptr >>> ...ufs-qcom.c:1201:40: >>> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio >>> ...ufs-qcom.c:1207:53: >>> warning: incorrect type in argument 1 (different address spaces) >>> ...ufs-qcom.c:1207:53: >>> expected void const *ptr >>> ...ufs-qcom.c:1207:53: >>> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio >>> >>> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org> >>> >>> --- >> What version of sparse do you use? You shouldn't need to do this. >> > i just updated my sparse to the newest - > so i'm using sparse 0.4.4 > and the command i use is: > make ARCH=arm C=1 CF="-Wsparse-all" > and i still get all the warnings. > with my patch, the are no warnings. > That is not the latest version of sparse. I'm not sure when sparse was updated, but I have the git version which shows v0.5.0-51-ga53cea28f0db
> On 10/27/2015 03:10 AM, ygardi@codeaurora.org wrote: >>> On 10/26/2015 08:41 AM, Yaniv Gardi wrote: >>>> Tnis patch fixes the following compilation warnings: >>>> ...ufs-qcom.c:1201:40: >>>> warning: incorrect type in argument 1 (different address spaces) >>>> ...ufs-qcom.c:1201:40: >>>> expected void const *ptr >>>> ...ufs-qcom.c:1201:40: >>>> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio >>>> ...ufs-qcom.c:1207:53: >>>> warning: incorrect type in argument 1 (different address spaces) >>>> ...ufs-qcom.c:1207:53: >>>> expected void const *ptr >>>> ...ufs-qcom.c:1207:53: >>>> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio >>>> >>>> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org> >>>> >>>> --- >>> What version of sparse do you use? You shouldn't need to do this. >>> >> i just updated my sparse to the newest - >> so i'm using sparse 0.4.4 >> and the command i use is: >> make ARCH=arm C=1 CF="-Wsparse-all" >> and i still get all the warnings. >> with my patch, the are no warnings. >> > > That is not the latest version of sparse. I'm not sure when sparse was > updated, but I have the git version which shows v0.5.0-51-ga53cea28f0db > Stephen, is this something you insist on? i think the patch can stay as it is. please let me know, as i wouldn't like this issue to block the entire patch Yaniv > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/27/2015 11:22 AM, ygardi@codeaurora.org wrote: >> On 10/27/2015 03:10 AM, ygardi@codeaurora.org wrote: >>>> On 10/26/2015 08:41 AM, Yaniv Gardi wrote: >>>>> Tnis patch fixes the following compilation warnings: >>>>> ...ufs-qcom.c:1201:40: >>>>> warning: incorrect type in argument 1 (different address spaces) >>>>> ...ufs-qcom.c:1201:40: >>>>> expected void const *ptr >>>>> ...ufs-qcom.c:1201:40: >>>>> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio >>>>> ...ufs-qcom.c:1207:53: >>>>> warning: incorrect type in argument 1 (different address spaces) >>>>> ...ufs-qcom.c:1207:53: >>>>> expected void const *ptr >>>>> ...ufs-qcom.c:1207:53: >>>>> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio >>>>> >>>>> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org> >>>>> >>>>> --- >>>> What version of sparse do you use? You shouldn't need to do this. >>>> >>> i just updated my sparse to the newest - >>> so i'm using sparse 0.4.4 >>> and the command i use is: >>> make ARCH=arm C=1 CF="-Wsparse-all" >>> and i still get all the warnings. >>> with my patch, the are no warnings. >>> >> That is not the latest version of sparse. I'm not sure when sparse was >> updated, but I have the git version which shows v0.5.0-51-ga53cea28f0db >> > Stephen, is this something you insist on? > i think the patch can stay as it is. > please let me know, as i wouldn't like this issue to block the entire patch > Yes. Adding __force is wrong. Just drop this patch.
diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index 72b0ef7..b57f88a 100644 --- a/drivers/scsi/ufs/ufs-qcom.c +++ b/drivers/scsi/ufs/ufs-qcom.c @@ -1226,11 +1226,12 @@ static int ufs_qcom_init(struct ufs_hba *hba) if (res) { host->dev_ref_clk_ctrl_mmio = devm_ioremap_resource(dev, res); - if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) { - dev_warn(dev, - "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n", + if (IS_ERR((__force void const *) + host->dev_ref_clk_ctrl_mmio)) { + dev_warn(dev, "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n", __func__, - PTR_ERR(host->dev_ref_clk_ctrl_mmio)); + PTR_ERR((__force void const *) + host->dev_ref_clk_ctrl_mmio)); host->dev_ref_clk_ctrl_mmio = NULL; } host->dev_ref_clk_en_mask = BIT(5);
Tnis patch fixes the following compilation warnings: ...ufs-qcom.c:1201:40: warning: incorrect type in argument 1 (different address spaces) ...ufs-qcom.c:1201:40: expected void const *ptr ...ufs-qcom.c:1201:40: got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio ...ufs-qcom.c:1207:53: warning: incorrect type in argument 1 (different address spaces) ...ufs-qcom.c:1207:53: expected void const *ptr ...ufs-qcom.c:1207:53: got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org> --- drivers/scsi/ufs/ufs-qcom.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)