diff mbox

[01/12] megaraid_sas : Expose TAPE drives unconditionally

Message ID 201510150816.t9F8GgOq029543@palmhbs0.lsi.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Sumit Saxena Oct. 15, 2015, 8:09 a.m. UTC 
Expose non-disk(TAPE drive, CD-ROM) unconditionally. This issue is reported in Redhat Bugzilla [Bug 1254762].

Cc: <stable@vger.kernel.org>
Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
Signed-off-by: Kashyap Desai <kashyap.desai@avagotech.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

Comments

Tomas Henzl Oct. 16, 2015, 2:26 p.m. UTC | #1 
On 15.10.2015 10:09, sumit.saxena@avagotech.com wrote:
> Expose non-disk(TAPE drive, CD-ROM) unconditionally. This issue is reported in Redhat Bugzilla [Bug 1254762].
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
> Signed-off-by: Kashyap Desai <kashyap.desai@avagotech.com>

Reviewed-by: Tomas Henzl <thenzl@redhat.com>

Tomas

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Martin K. Petersen Oct. 28, 2015, 2:13 a.m. UTC | #2 
Sumit> Expose non-disk(TAPE drive, CD-ROM) unconditionally. This issue
Sumit> is reported in Redhat Bugzilla [Bug 1254762].

RH bugzilla is not public so I removed this blurb from the patch
description.

In the future, please drop the spaces after megaraid_sas in patch
header. I fixed those up for now.
Sumit Saxena Oct. 28, 2015, 10:58 a.m. UTC | #3 
> -----Original Message-----
> From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
> Sent: Wednesday, October 28, 2015 7:44 AM
> To: sumit.saxena@avagotech.com
> Cc: linux-scsi@vger.kernel.org; stable@vger.kernel.org;
thenzl@redhat.com;
> martin.petersen@oracle.com; hch@infradead.org; jbottomley@parallels.com;
> kashyap.desai@avagotech.com; kiran-kumar.kasturi@avagotech.com;
> uday.lingala@avagotech.com
> Subject: Re: [PATCH 01/12] megaraid_sas : Expose TAPE drives
unconditionally
>
>
> Sumit> Expose non-disk(TAPE drive, CD-ROM) unconditionally. This issue
> Sumit> is reported in Redhat Bugzilla [Bug 1254762].
>
> RH bugzilla is not public so I removed this blurb from the patch
description.
>
> In the future, please drop the spaces after megaraid_sas in patch
header. I fixed
> those up for now.
Sure, I will take care of it while sending patches in future.

Thanks,
Sumit
>
> --
> Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index d2ebcdd..d00d494 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -1743,8 +1743,9 @@  static int megasas_slave_alloc(struct scsi_device *sdev)
 		pd_index =
 			(sdev->channel * MEGASAS_MAX_DEV_PER_CHANNEL) +
 			sdev->id;
-		if (instance->pd_list[pd_index].driveState ==
-					MR_PD_STATE_SYSTEM) {
+		if ((instance->pd_list[pd_index].driveState ==
+			MR_PD_STATE_SYSTEM) ||
+			(instance->pd_list[pd_index].driveType != TYPE_DISK)) {
 			return 0;
 		}
 		return -ENXIO;