| Message ID | 1445993915-111262-3-git-send-email-eli@mellanox.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wed, Oct 28, 2015 at 02:58:35AM +0200, Eli Cohen wrote: > Signed-off-by: Eli Cohen <eli@mellanox.com> > drivers/infiniband/hw/mlx5/main.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c > index f1ccd40..634de84 100644 > +++ b/drivers/infiniband/hw/mlx5/main.c > @@ -1385,7 +1385,8 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev) > (1ull << IB_USER_VERBS_CMD_CREATE_XSRQ) | > (1ull << IB_USER_VERBS_CMD_OPEN_QP); > dev->ib_dev.uverbs_ex_cmd_mask = > - (1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE); > + (1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE) | > + (1ull << IB_USER_VERBS_EX_CMD_CREATE_QP); Same comment as last time. http://thread.gmane.org/gmane.linux.drivers.rdma/26110/focus=26163 This still hasn't been fixed. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Same comment as last time. > > http://thread.gmane.org/gmane.linux.drivers.rdma/26110/focus=26163 > >This still hasn't been fixed. Jason, The relevant IB core patches have been accepted. Can you elaborate more on what your comments against this are? https://github.com/dledford/linux/commit/6d8a74972b7115b41d4d17a4444c026755ca24be -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Oct 28, 2015 at 06:18:27PM +0000, Eli Cohen wrote: > > Same comment as last time. > > > > http://thread.gmane.org/gmane.linux.drivers.rdma/26110/focus=26163 > > > >This still hasn't been fixed. > > Jason, > > The relevant IB core patches have been accepted. Can you elaborate more on > what your comments against this are? Did you read the above thread? Don't set uverbs_ex_cmd_mask in drivers. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Did you read the above thread? > > Don't set uverbs_ex_cmd_mask in drivers. But that's not how it is currently. IB core does not set any of the extended verbs flags for all the devices. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Oct 28, 2015 at 06:44:05PM +0000, Eli Cohen wrote: > > Did you read the above thread? > > > > Don't set uverbs_ex_cmd_mask in drivers. > > But that's not how it is currently. IB core does not set any of the > extended verbs flags for all the devices. We agreed it would be fixed as a follow up patch so the timestamp stuff could move forward. That patch never came, and now it is needed before more stuff does this wrong. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Following this email is another one with the fix. -----Original Message----- From: Jason Gunthorpe [mailto:jgunthorpe@obsidianresearch.com] Sent: Wednesday, October 28, 2015 2:20 PM To: Eli Cohen <eli@mellanox.com> Cc: dledford@redhat.com; linux-rdma@vger.kernel.org; Or Gerlitz <ogerlitz@mellanox.com>; Eran Ben Elisha <eranbe@mellanox.com>; cl@linux.com Subject: Re: [PATCH 2/2] IB/mlx5: Publish mlx5 driver support for extended create QP On Wed, Oct 28, 2015 at 06:44:05PM +0000, Eli Cohen wrote: > > Did you read the above thread? > > > > Don't set uverbs_ex_cmd_mask in drivers. > > But that's not how it is currently. IB core does not set any of the > extended verbs flags for all the devices. We agreed it would be fixed as a follow up patch so the timestamp stuff could move forward. That patch never came, and now it is needed before more stuff does this wrong. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index f1ccd40..634de84 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -1385,7 +1385,8 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev) (1ull << IB_USER_VERBS_CMD_CREATE_XSRQ) | (1ull << IB_USER_VERBS_CMD_OPEN_QP); dev->ib_dev.uverbs_ex_cmd_mask = - (1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE); + (1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE) | + (1ull << IB_USER_VERBS_EX_CMD_CREATE_QP); dev->ib_dev.query_device = mlx5_ib_query_device; dev->ib_dev.query_port = mlx5_ib_query_port;
Signed-off-by: Eli Cohen <eli@mellanox.com> --- drivers/infiniband/hw/mlx5/main.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)