| Message ID | 1303291342-27668-5-git-send-email-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 20 Apr 2011 10:22:20 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote: > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Keith Packard <keithp@keithp.com> (this might be separately tested to see if it might fix some TV load detection issues?)
On Wed, 20 Apr 2011 11:23:01 -0700, Keith Packard <keithp@keithp.com> wrote: > On Wed, 20 Apr 2011 10:22:20 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote: > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Reviewed-by: Keith Packard <keithp@keithp.com> > > (this might be separately tested to see if it might fix some TV load > detection issues?) It is an old bug along a dead code path. It can simply be squashed with the next patch that removes it entirely, if you prefer. -Chris
On Wed, 20 Apr 2011 20:38:54 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote: > On Wed, 20 Apr 2011 11:23:01 -0700, Keith Packard <keithp@keithp.com> wrote: > > On Wed, 20 Apr 2011 10:22:20 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote: > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > > > Reviewed-by: Keith Packard <keithp@keithp.com> > > > > (this might be separately tested to see if it might fix some TV load > > detection issues?) > > It is an old bug along a dead code path. It can simply be squashed with > the next patch that removes it entirely, if you prefer. Right, I didn't look forward to see that it was in 're-use existing pipe' path which has been dead for a long time now.
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 0d8d5e2..61fa02f 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -5622,7 +5622,7 @@ bool intel_get_load_detect_pipe(struct intel_encoder *intel_encoder, } /* Add this connector to the crtc */ - encoder_funcs->mode_set(encoder, &crtc->mode, &crtc->mode); + encoder_funcs->mode_set(encoder, &crtc->mode, &crtc->hwmode); encoder_funcs->commit(encoder); }
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)