diff mbox

kbuild: fix W=1 with gcc 4.3.2

Message ID 20110421210852.GA6196@merkur.ravnborg.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sam Ravnborg April 21, 2011, 9:08 p.m. UTC
Building a kernel using W=1 with gcc 4.3.2 failed like this:

    cc1: error: unrecognized command line option "-Wpacked-bitfield-compat"

Make use of this option dependent on the compiler.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Dave Jones <davej@redhat.com>
---
I do not see this a stable material - people running stable kernels
have less value of W=1.

And the amount of warnings are outright silly. We should really
divide this up a bit so W=1 is semi usefull.

	Sam

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Eric Dumazet April 21, 2011, 9:13 p.m. UTC | #1
Le jeudi 21 avril 2011 à 23:08 +0200, Sam Ravnborg a écrit :
> Building a kernel using W=1 with gcc 4.3.2 failed like this:
> 
>     cc1: error: unrecognized command line option "-Wpacked-bitfield-compat"
> 
> Make use of this option dependent on the compiler.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Dave Jones <davej@redhat.com>
> ---
> I do not see this a stable material - people running stable kernels
> have less value of W=1.
> 
> And the amount of warnings are outright silly. We should really
> divide this up a bit so W=1 is semi usefull.
> 
> 	Sam
> 
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index d5f925a..b280284 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -73,7 +73,7 @@ KBUILD_EXTRA_WARNINGS += -Wnested-externs
>  KBUILD_EXTRA_WARNINGS += -Wold-style-definition
>  KBUILD_EXTRA_WARNINGS += $(call cc-option, -Woverlength-strings,)
>  KBUILD_EXTRA_WARNINGS += -Wpacked
> -KBUILD_EXTRA_WARNINGS += -Wpacked-bitfield-compat
> +KBUILD_EXTRA_WARNINGS += $(call cc-option, -Wpacked-bitfield-compat)
>  KBUILD_EXTRA_WARNINGS += -Wpadded
>  KBUILD_EXTRA_WARNINGS += -Wpointer-arith
>  KBUILD_EXTRA_WARNINGS += -Wredundant-decls
> --

Please add same fix for gcc-4.1.2

cc1: error: unrecognized command line option "-Wlogical-op"





--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Joe Perches April 21, 2011, 9:17 p.m. UTC | #2
On Thu, 2011-04-21 at 23:13 +0200, Eric Dumazet wrote:
> Le jeudi 21 avril 2011 à 23:08 +0200, Sam Ravnborg a écrit :
> > diff --git a/scripts/Makefile.build b/scripts/Makefile.build
[]
> > index d5f925a..b280284 100644
> > --- a/scripts/Makefile.build
> > +++ b/scripts/Makefile.build
> > @@ -73,7 +73,7 @@ KBUILD_EXTRA_WARNINGS += -Wnested-externs
> >  KBUILD_EXTRA_WARNINGS += -Wold-style-definition
> >  KBUILD_EXTRA_WARNINGS += $(call cc-option, -Woverlength-strings,)
> >  KBUILD_EXTRA_WARNINGS += -Wpacked
> > -KBUILD_EXTRA_WARNINGS += -Wpacked-bitfield-compat
> > +KBUILD_EXTRA_WARNINGS += $(call cc-option, -Wpacked-bitfield-compat)
> >  KBUILD_EXTRA_WARNINGS += -Wpadded
> >  KBUILD_EXTRA_WARNINGS += -Wpointer-arith
> >  KBUILD_EXTRA_WARNINGS += -Wredundant-decls
> > --
> Please add same fix for gcc-4.1.2
> cc1: error: unrecognized command line option "-Wlogical-op"

Maybe it'd be easier if all of these were
$(call cc-option, ...)


--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index d5f925a..b280284 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -73,7 +73,7 @@  KBUILD_EXTRA_WARNINGS += -Wnested-externs
 KBUILD_EXTRA_WARNINGS += -Wold-style-definition
 KBUILD_EXTRA_WARNINGS += $(call cc-option, -Woverlength-strings,)
 KBUILD_EXTRA_WARNINGS += -Wpacked
-KBUILD_EXTRA_WARNINGS += -Wpacked-bitfield-compat
+KBUILD_EXTRA_WARNINGS += $(call cc-option, -Wpacked-bitfield-compat)
 KBUILD_EXTRA_WARNINGS += -Wpadded
 KBUILD_EXTRA_WARNINGS += -Wpointer-arith
 KBUILD_EXTRA_WARNINGS += -Wredundant-decls