| Message ID | 1447312196-11470-1-git-send-email-acourbot@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Nov 12, 2015 at 04:09:56PM +0900, Alexandre Courbot wrote: > drm_gem_object_unreference() now expects obj->dev->struct_mutex to be > held. Use the newly-introduced drm_gem_object_unreference_unlocked() > which handles locking for us. This rule has been really old, I simply made the checking more anal in commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663 Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Thu Oct 15 09:36:25 2015 +0200 drm/gem: Check locking in drm_gem_object_unreference With the above added this is: Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > If we don't do this drm_gem_object_unreference() will get noisy about > struct_mutex not being held every time we call the SET_TILING ioctl. > > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> > --- > drivers/gpu/drm/tegra/drm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c > index cc48334ef164..c0ae89865958 100644 > --- a/drivers/gpu/drm/tegra/drm.c > +++ b/drivers/gpu/drm/tegra/drm.c > @@ -683,7 +683,7 @@ static int tegra_gem_set_tiling(struct drm_device *drm, void *data, > bo->tiling.mode = mode; > bo->tiling.value = value; > > - drm_gem_object_unreference(gem); > + drm_gem_object_unreference_unlocked(gem); > > return 0; > } > -- > 2.6.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
On Tue, Nov 17, 2015 at 7:02 PM, Daniel Vetter <daniel@ffwll.ch> wrote: > On Thu, Nov 12, 2015 at 04:09:56PM +0900, Alexandre Courbot wrote: >> drm_gem_object_unreference() now expects obj->dev->struct_mutex to be >> held. Use the newly-introduced drm_gem_object_unreference_unlocked() >> which handles locking for us. > > This rule has been really old, I simply made the checking more anal in > > commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663 > Author: Daniel Vetter <daniel.vetter@ffwll.ch> > Date: Thu Oct 15 09:36:25 2015 +0200 > > drm/gem: Check locking in drm_gem_object_unreference > > With the above added this is: > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch Thanks! Sending an updated version.
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index cc48334ef164..c0ae89865958 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu/drm/tegra/drm.c @@ -683,7 +683,7 @@ static int tegra_gem_set_tiling(struct drm_device *drm, void *data, bo->tiling.mode = mode; bo->tiling.value = value; - drm_gem_object_unreference(gem); + drm_gem_object_unreference_unlocked(gem); return 0; }
drm_gem_object_unreference() now expects obj->dev->struct_mutex to be held. Use the newly-introduced drm_gem_object_unreference_unlocked() which handles locking for us. If we don't do this drm_gem_object_unreference() will get noisy about struct_mutex not being held every time we call the SET_TILING ioctl. Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> --- drivers/gpu/drm/tegra/drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)