| Message ID | 1447936699-26854-1-git-send-email-clabbe.montjoie@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
On Thu, Nov 19, 2015 at 01:38:17PM +0100, LABBE Corentin wrote: > The two unsigned int variables nb_in_sg and nb_out_sg can be assigned > signed value (-EINVAL) from sg_nents_for_len(). > Furthermore they are used only by dma_map_sg and dma_unmap_sg which wait > for an signed int, so they must be set as int. > > Fixes: 6c2b74d4774f ("crypto: sahara - check return value of sg_nents_for_len") > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> Both patches applied. Thanks.
diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c index ea9f56a..cc738f3 100644 --- a/drivers/crypto/sahara.c +++ b/drivers/crypto/sahara.c @@ -228,9 +228,9 @@ struct sahara_dev { size_t total; struct scatterlist *in_sg; - unsigned int nb_in_sg; + int nb_in_sg; struct scatterlist *out_sg; - unsigned int nb_out_sg; + int nb_out_sg; u32 error; };
The two unsigned int variables nb_in_sg and nb_out_sg can be assigned signed value (-EINVAL) from sg_nents_for_len(). Furthermore they are used only by dma_map_sg and dma_unmap_sg which wait for an signed int, so they must be set as int. Fixes: 6c2b74d4774f ("crypto: sahara - check return value of sg_nents_for_len") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> --- drivers/crypto/sahara.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)