| Message ID | 1448273816-11290-5-git-send-email-carlo@caione.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 23, 2015 at 11:16:55AM +0100, Carlo Caione wrote: > From: Carlo Caione <carlo@endlessm.com> > > Extend the pinctrl binding documentation with the support for external > GPIO interrupts. > > Signed-off-by: Carlo Caione <carlo@endlessm.com> > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> > --- > Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > index 3f6a524..56743eb 100644 > --- a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > @@ -3,6 +3,12 @@ > Required properties for the root node: > - compatible: "amlogic,meson8-pinctrl" or "amlogic,meson8b-pinctrl" > - reg: address and size of registers controlling irq functionality > + - reg-names: should be "irq" You don't really need names when there is only one. Otherwise: Acked-by: Rob Herring <robh@kernel.org> > + - interrupt-controller: marks the device node as an interrupt controller > + - #interrupt-cells: should be 2. The first cell is the GPIO number. The > + second cell is used to specify trigger type. > + - interrupts: specifies the GPIO IRQ numbers on the GIC (GPIO_IRQ#) > + - interrupt-parent: specifies the parent interrupt controller. > > === GPIO sub-nodes === > > @@ -46,7 +52,13 @@ pinctrl-bindings.txt > > pinctrl: pinctrl@c1109880 { > compatible = "amlogic,meson8-pinctrl"; > + reg-names = "irq"; > reg = <0xc1109880 0x10>; > + interrupt-parent = <&gic>; > + interrupts = <0 64 1>, <0 65 1>, <0 66 1>, <0 67 1>, > + <0 68 1>, <0 69 1>, <0 70 1>, <0 71 1>; > + interrupt-controller; > + #interrupt-cells = <2>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > -- > 2.5.0 >
On lun, nov 23, 2015 at 05:47:20 -0600, Rob Herring wrote: > On Mon, Nov 23, 2015 at 11:16:55AM +0100, Carlo Caione wrote: > > From: Carlo Caione <carlo@endlessm.com> > > > > Extend the pinctrl binding documentation with the support for external > > GPIO interrupts. > > > > Signed-off-by: Carlo Caione <carlo@endlessm.com> > > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> > > --- > > Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > > index 3f6a524..56743eb 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > > +++ b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > > @@ -3,6 +3,12 @@ > > Required properties for the root node: > > - compatible: "amlogic,meson8-pinctrl" or "amlogic,meson8b-pinctrl" > > - reg: address and size of registers controlling irq functionality > > + - reg-names: should be "irq" > > You don't really need names when there is only one. Otherwise: > > Acked-by: Rob Herring <robh@kernel.org> I missed this reply sorry. The name is conveniently used so that I can use the meson_map_resource() helper function to map that and get back the regmap struct in one shot. I'm going to submit v3 soon without this modification leaving out your Acked-by. Let me know if your ACK is still valid without this code change.
diff --git a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt index 3f6a524..56743eb 100644 --- a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt @@ -3,6 +3,12 @@ Required properties for the root node: - compatible: "amlogic,meson8-pinctrl" or "amlogic,meson8b-pinctrl" - reg: address and size of registers controlling irq functionality + - reg-names: should be "irq" + - interrupt-controller: marks the device node as an interrupt controller + - #interrupt-cells: should be 2. The first cell is the GPIO number. The + second cell is used to specify trigger type. + - interrupts: specifies the GPIO IRQ numbers on the GIC (GPIO_IRQ#) + - interrupt-parent: specifies the parent interrupt controller. === GPIO sub-nodes === @@ -46,7 +52,13 @@ pinctrl-bindings.txt pinctrl: pinctrl@c1109880 { compatible = "amlogic,meson8-pinctrl"; + reg-names = "irq"; reg = <0xc1109880 0x10>; + interrupt-parent = <&gic>; + interrupts = <0 64 1>, <0 65 1>, <0 66 1>, <0 67 1>, + <0 68 1>, <0 69 1>, <0 70 1>, <0 71 1>; + interrupt-controller; + #interrupt-cells = <2>; #address-cells = <1>; #size-cells = <1>; ranges;