| Message ID | 1448523815-24562-3-git-send-email-anil.gurumurthy@qlogic.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2015-11-26 at 02:43 -0500, anil.gurumurthy@qlogic.com wrote: > From: Anil Gurumurthy <anil.gurumurthy@qlogic.com> Can you please explain a bit more why it is crashing in the commit message, i.e. copy the comment you added to the source here as well. And as I spot the words fix and crash in the subject, you might consider adding a Cc: stable@vger.kernel.org Thanks, Johannes > > Signed-off-by: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com> > Signed-off-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com> > --- > drivers/scsi/bfa/bfad_im.c | 26 ++++++++++++++++++++++++++ > 1 files changed, 26 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c > index efcb247..2c0cf8a 100644 > --- a/drivers/scsi/bfa/bfad_im.c > +++ b/drivers/scsi/bfa/bfad_im.c > @@ -272,6 +272,19 @@ bfad_im_target_reset_send(struct bfad_s *bfad, struct > scsi_cmnd *cmnd, > cmnd->host_scribble = NULL; > cmnd->SCp.Status = 0; > bfa_itnim = bfa_fcs_itnim_get_halitn(&itnim->fcs_itnim); > + /* > + * bfa_itnim can be NULL if the port gets disconnected and the bfa > + * and fcs layers have cleaned up their nexus with the targets and > + * the same has not been cleaned up by the shim > + */ > + if (bfa_itnim == NULL) { > + bfa_tskim_free(tskim); > + BFA_LOG(KERN_ERR, bfad, bfa_log_level, > + "target reset, bfa_itnim is NULL\n"); > + rc = BFA_STATUS_FAILED; > + goto out; > + } > + > memset(&scsilun, 0, sizeof(scsilun)); > bfa_tskim_start(tskim, bfa_itnim, scsilun, > FCP_TM_TARGET_RESET, BFAD_TARGET_RESET_TMO); > @@ -327,6 +340,19 @@ bfad_im_reset_lun_handler(struct scsi_cmnd *cmnd) > cmnd->SCp.ptr = (char *)&wq; > cmnd->SCp.Status = 0; > bfa_itnim = bfa_fcs_itnim_get_halitn(&itnim->fcs_itnim); > + /* > + * bfa_itnim can be NULL if the port gets disconnected and the bfa > + * and fcs layers have cleaned up their nexus with the targets and > + * the same has not been cleaned up by the shim > + */ > + if (bfa_itnim == NULL) { > + bfa_tskim_free(tskim); > + BFA_LOG(KERN_ERR, bfad, bfa_log_level, > + "lun reset, bfa_itnim is NULL\n"); > + spin_unlock_irqrestore(&bfad->bfad_lock, flags); > + rc = FAILED; > + goto out; > + } > int_to_scsilun(cmnd->device->lun, &scsilun); > bfa_tskim_start(tskim, bfa_itnim, scsilun, > FCP_TM_LUN_RESET, BFAD_LUN_RESET_TMO); -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks Johannes, will repost the patch set. -----Original Message----- From: Johannes Thumshirn [mailto:jthumshirn@suse.de] Sent: 26 November 2015 14:06 To: Anil Gurumurthy <Anil.Gurumurthy@qlogic.com>; martin.petersen@oracle.com; James.Bottomley@HansenPartnership.com Cc: linux-scsi <linux-scsi@vger.kernel.org>; Sudarsana Kalluru <Sudarsana.Kalluru@qlogic.com> Subject: Re: [PATCH 2/4] bfa:Fix for crash when bfa_itnim is NULL On Thu, 2015-11-26 at 02:43 -0500, anil.gurumurthy@qlogic.com wrote: > From: Anil Gurumurthy <anil.gurumurthy@qlogic.com> Can you please explain a bit more why it is crashing in the commit message, i.e. copy the comment you added to the source here as well. And as I spot the words fix and crash in the subject, you might consider adding a Cc: stable@vger.kernel.org Thanks, Johannes > > Signed-off-by: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com> > Signed-off-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com> > --- > drivers/scsi/bfa/bfad_im.c | 26 ++++++++++++++++++++++++++ > 1 files changed, 26 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c > index efcb247..2c0cf8a 100644 > --- a/drivers/scsi/bfa/bfad_im.c > +++ b/drivers/scsi/bfa/bfad_im.c > @@ -272,6 +272,19 @@ bfad_im_target_reset_send(struct bfad_s *bfad, > struct scsi_cmnd *cmnd, > cmnd->host_scribble = NULL; > cmnd->SCp.Status = 0; > bfa_itnim = bfa_fcs_itnim_get_halitn(&itnim->fcs_itnim); > + /* > + * bfa_itnim can be NULL if the port gets disconnected and the bfa > + * and fcs layers have cleaned up their nexus with the targets and > + * the same has not been cleaned up by the shim > + */ > + if (bfa_itnim == NULL) { > + bfa_tskim_free(tskim); > + BFA_LOG(KERN_ERR, bfad, bfa_log_level, > + "target reset, bfa_itnim is NULL\n"); > + rc = BFA_STATUS_FAILED; > + goto out; > + } > + > memset(&scsilun, 0, sizeof(scsilun)); > bfa_tskim_start(tskim, bfa_itnim, scsilun, > FCP_TM_TARGET_RESET, BFAD_TARGET_RESET_TMO); @@ -327,6 +340,19 > @@ bfad_im_reset_lun_handler(struct scsi_cmnd *cmnd) > cmnd->SCp.ptr = (char *)&wq; > cmnd->SCp.Status = 0; > bfa_itnim = bfa_fcs_itnim_get_halitn(&itnim->fcs_itnim); > + /* > + * bfa_itnim can be NULL if the port gets disconnected and the bfa > + * and fcs layers have cleaned up their nexus with the targets and > + * the same has not been cleaned up by the shim > + */ > + if (bfa_itnim == NULL) { > + bfa_tskim_free(tskim); > + BFA_LOG(KERN_ERR, bfad, bfa_log_level, > + "lun reset, bfa_itnim is NULL\n"); > + spin_unlock_irqrestore(&bfad->bfad_lock, flags); > + rc = FAILED; > + goto out; > + } > int_to_scsilun(cmnd->device->lun, &scsilun); > bfa_tskim_start(tskim, bfa_itnim, scsilun, > FCP_TM_LUN_RESET, BFAD_LUN_RESET_TMO);
diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c index efcb247..2c0cf8a 100644 --- a/drivers/scsi/bfa/bfad_im.c +++ b/drivers/scsi/bfa/bfad_im.c @@ -272,6 +272,19 @@ bfad_im_target_reset_send(struct bfad_s *bfad, struct scsi_cmnd *cmnd, cmnd->host_scribble = NULL; cmnd->SCp.Status = 0; bfa_itnim = bfa_fcs_itnim_get_halitn(&itnim->fcs_itnim); + /* + * bfa_itnim can be NULL if the port gets disconnected and the bfa + * and fcs layers have cleaned up their nexus with the targets and + * the same has not been cleaned up by the shim + */ + if (bfa_itnim == NULL) { + bfa_tskim_free(tskim); + BFA_LOG(KERN_ERR, bfad, bfa_log_level, + "target reset, bfa_itnim is NULL\n"); + rc = BFA_STATUS_FAILED; + goto out; + } + memset(&scsilun, 0, sizeof(scsilun)); bfa_tskim_start(tskim, bfa_itnim, scsilun, FCP_TM_TARGET_RESET, BFAD_TARGET_RESET_TMO); @@ -327,6 +340,19 @@ bfad_im_reset_lun_handler(struct scsi_cmnd *cmnd) cmnd->SCp.ptr = (char *)&wq; cmnd->SCp.Status = 0; bfa_itnim = bfa_fcs_itnim_get_halitn(&itnim->fcs_itnim); + /* + * bfa_itnim can be NULL if the port gets disconnected and the bfa + * and fcs layers have cleaned up their nexus with the targets and + * the same has not been cleaned up by the shim + */ + if (bfa_itnim == NULL) { + bfa_tskim_free(tskim); + BFA_LOG(KERN_ERR, bfad, bfa_log_level, + "lun reset, bfa_itnim is NULL\n"); + spin_unlock_irqrestore(&bfad->bfad_lock, flags); + rc = FAILED; + goto out; + } int_to_scsilun(cmnd->device->lun, &scsilun); bfa_tskim_start(tskim, bfa_itnim, scsilun, FCP_TM_LUN_RESET, BFAD_LUN_RESET_TMO);