| Message ID | 1448709248-21177-2-git-send-email-sebastian.hesselbarth@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote: > Current NAND node has an additional flash partition for the whole > flash overlapping with real partitions. Remove this partition as > the whole flash is already represented by the NAND device itself. If i remember correctly, we discussed this when the contribution was made. I think the stock firmware might use this for applying updates. Maybe Benoit can comment? If so, removing this will break compatibility with stock firmware. Do we want to do that? There are a few other mvebu dts files with a partition spanning the whole flash. Should we remove them as well? Andrew
On 28.11.2015 17:52, Andrew Lunn wrote: > On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote: >> Current NAND node has an additional flash partition for the whole >> flash overlapping with real partitions. Remove this partition as >> the whole flash is already represented by the NAND device itself. > > If i remember correctly, we discussed this when the contribution was > made. I think the stock firmware might use this for applying updates. > Maybe Benoit can comment? Yes, please. > If so, removing this will break compatibility with stock firmware. Do > we want to do that? There are a few other mvebu dts files with a > partition spanning the whole flash. Should we remove them as well? Well, there is already a mtd device that spans the whole flash so what is the purpose of another "partition" that isn't a part but all of the device? Actually, I doubt that a FW update will wipe the flash as a whole, i.e. including boot loader, boot env, user config. Anyway, let's see if Benoit can shed some light on this. FWIW, neither single partitions nor a combined partitions node should be a direct sub-node of the _controller_ but a NAND _device_ node instead. Luckily, multi-device systems are not that common, so I guess we wait with it until such a system pops up for testing. Sebastian
From mobile > Le 28 nov. 2015 à 18:38, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> a écrit : > >> On 28.11.2015 17:52, Andrew Lunn wrote: >>> On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote: >>> Current NAND node has an additional flash partition for the whole >>> flash overlapping with real partitions. Remove this partition as >>> the whole flash is already represented by the NAND device itself. >> >> If i remember correctly, we discussed this when the contribution was >> made. I think the stock firmware might use this for applying updates. >> Maybe Benoit can comment? > > Yes, please. From my memory since I'm not running the stock firmware it uses the MTD device directly. This is safe to remove. I was not very contort able with this flash dts part it was copied over from a netgear mevbu device ... > >> If so, removing this will break compatibility with stock firmware. Do >> we want to do that? There are a few other mvebu dts files with a >> partition spanning the whole flash. Should we remove them as well? > > Well, there is already a mtd device that spans the whole flash so > what is the purpose of another "partition" that isn't a part but > all of the device? Actually, I doubt that a FW update will wipe > the flash as a whole, i.e. including boot loader, boot env, user > config. > > Anyway, let's see if Benoit can shed some light on this. > > FWIW, neither single partitions nor a combined partitions node > should be a direct sub-node of the _controller_ but a NAND > _device_ node instead. Luckily, multi-device systems are not that > common, so I guess we wait with it until such a system pops up for > testing. > > Sebastian > >
>On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote: > Current NAND node has an additional flash partition for the whole > flash overlapping with real partitions. Remove this partition as > the whole flash is already represented by the NAND device itself. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Given Benoit comment Acked-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hi Sebastian and Andrew, On sam., nov. 28 2015, Andrew Lunn <andrew@lunn.ch> wrote: >>On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote: >> Current NAND node has an additional flash partition for the whole >> flash overlapping with real partitions. Remove this partition as >> the whole flash is already represented by the NAND device itself. >> >> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > Given Benoit comment > > Acked-by: Andrew Lunn <andrew@lunn.ch> Applied on mvebu/dt Thanks, Gregory > > Andrew
diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts index 58b500873bfd..30a0a6eac645 100644 --- a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts +++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts @@ -183,11 +183,6 @@ label = "boot"; reg = <0xE00000 0x3F200000>; }; - - partition@flash { - label = "flash"; - reg = <0x0 0x40000000>; - }; }; }; };
Current NAND node has an additional flash partition for the whole flash overlapping with real partitions. Remove this partition as the whole flash is already represented by the NAND device itself. Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> --- Cc: Jason Cooper <jason@lakedaemon.net> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Gregory Clement <gregory.clement@free-electrons.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Pawel Moll <pawel.moll@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> Cc: Kumar Gala <galak@codeaurora.org> Cc: Russell King <linux@arm.linux.org.uk> Cc: Benoit Masson <yahoo@perenite.com> Cc: linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 5 ----- 1 file changed, 5 deletions(-)