| Message ID | 1449460394-31601-1-git-send-email-bayi.cheng@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Bayi, On Mon, Dec 7, 2015 at 11:53 AM, Bayi Cheng <bayi.cheng@mediatek.com> wrote: > Add Mediatek nor flash node > > Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com> > Acked-by: Brian Norris <computersforpeace@gmail.com> > --- > Previous version of this patch is > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/386005.html > Drop flash node from mt8173.dtsi accroding review comment Is there a flash on mt8173-evb that can be accessed by the nor_flash ? If so, can you include flash@0 node in the mt8173-evb.dts. -Dan > > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 4dd5f93..af08e97 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -387,6 +387,17 @@ > status = "disabled"; > }; > > + nor_flash: spi@1100d000 { > + compatible = "mediatek,mt8173-nor"; > + reg = <0 0x1100d000 0 0xe0>; > + clocks = <&pericfg CLK_PERI_SPI>, > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>; > + clock-names = "spi", "sf"; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > i2c3: i2c@11010000 { > compatible = "mediatek,mt8173-i2c"; > reg = <0 0x11010000 0 0x70>, > -- > 1.8.1.1.dirty >
On Mon, 2015-12-07 at 12:09 +0800, Daniel Kurtz wrote: > Bayi, > > On Mon, Dec 7, 2015 at 11:53 AM, Bayi Cheng <bayi.cheng@mediatek.com> wrote: > > Add Mediatek nor flash node > > > > Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com> > > Acked-by: Brian Norris <computersforpeace@gmail.com> > > --- > > Previous version of this patch is > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/386005.html > > Drop flash node from mt8173.dtsi accroding review comment > > Is there a flash on mt8173-evb that can be accessed by the nor_flash ? > If so, can you include flash@0 node in the mt8173-evb.dts. > > -Dan > Hi Daniel, Thanks for your comments! you are right, there is a flash on mt8173-evb which can be accessed by the nor_flash, and I will include flash@0 node in mt8173-evb.dts (kernel v3.18) too. Bayi > > > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > index 4dd5f93..af08e97 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -387,6 +387,17 @@ > > status = "disabled"; > > }; > > > > + nor_flash: spi@1100d000 { > > + compatible = "mediatek,mt8173-nor"; > > + reg = <0 0x1100d000 0 0xe0>; > > + clocks = <&pericfg CLK_PERI_SPI>, > > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>; > > + clock-names = "spi", "sf"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + }; > > + > > i2c3: i2c@11010000 { > > compatible = "mediatek,mt8173-i2c"; > > reg = <0 0x11010000 0 0x70>, > > -- > > 1.8.1.1.dirty > >
On Mon, 2015-12-07 at 12:34 +0800, bayi cheng wrote: > On Mon, 2015-12-07 at 12:09 +0800, Daniel Kurtz wrote: > > Bayi, > > > > On Mon, Dec 7, 2015 at 11:53 AM, Bayi Cheng <bayi.cheng@mediatek.com> wrote: > > > Add Mediatek nor flash node > > > > > > Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com> > > > Acked-by: Brian Norris <computersforpeace@gmail.com> > > > --- > > > Previous version of this patch is > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/386005.html > > > Drop flash node from mt8173.dtsi accroding review comment > > > > Is there a flash on mt8173-evb that can be accessed by the nor_flash ? > > If so, can you include flash@0 node in the mt8173-evb.dts. > > > > -Dan > > > Hi Daniel, Thanks for your comments! you are right, there is a flash on > mt8173-evb which can be accessed by the nor_flash, and I will include > flash@0 node in mt8173-evb.dts (kernel v3.18) too. > > Bayi Hi Dan, I have reworked a EVB board for spi nor verify, we replaced the spi nand flash with spi nor flash on EVB board, and our shipping EVB board haven't support spi nor flash, So I will not include flash@0 node in the mt8173-evb.dts. I am sorry to made you confused! Bayi > > > > > > --- > > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > > index 4dd5f93..af08e97 100644 > > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > > @@ -387,6 +387,17 @@ > > > status = "disabled"; > > > }; > > > > > > + nor_flash: spi@1100d000 { > > > + compatible = "mediatek,mt8173-nor"; > > > + reg = <0 0x1100d000 0 0xe0>; > > > + clocks = <&pericfg CLK_PERI_SPI>, > > > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>; > > > + clock-names = "spi", "sf"; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + status = "disabled"; > > > + }; > > > + > > > i2c3: i2c@11010000 { > > > compatible = "mediatek,mt8173-i2c"; > > > reg = <0 0x11010000 0 0x70>, > > > -- > > > 1.8.1.1.dirty > > > > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
Bayi, On Mon, Dec 7, 2015 at 12:46 PM, bayi cheng <bayi.cheng@mediatek.com> wrote: > On Mon, 2015-12-07 at 12:34 +0800, bayi cheng wrote: >> On Mon, 2015-12-07 at 12:09 +0800, Daniel Kurtz wrote: >> > Bayi, >> > >> > On Mon, Dec 7, 2015 at 11:53 AM, Bayi Cheng <bayi.cheng@mediatek.com> wrote: >> > > Add Mediatek nor flash node >> > > >> > > Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com> >> > > Acked-by: Brian Norris <computersforpeace@gmail.com> >> > > --- >> > > Previous version of this patch is >> > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/386005.html >> > > Drop flash node from mt8173.dtsi accroding review comment >> > >> > Is there a flash on mt8173-evb that can be accessed by the nor_flash ? >> > If so, can you include flash@0 node in the mt8173-evb.dts. >> > >> > -Dan >> > >> Hi Daniel, Thanks for your comments! you are right, there is a flash on >> mt8173-evb which can be accessed by the nor_flash, and I will include >> flash@0 node in mt8173-evb.dts (kernel v3.18) too. >> >> Bayi > > Hi Dan, I have reworked a EVB board for spi nor verify, we replaced the > spi nand flash with spi nor flash on EVB board, > and our shipping EVB board haven't support spi nor flash, So I will not > include flash@0 node in the mt8173-evb.dts. I am sorry to made you > confused! Thanks for confirming. Reviewed-by: Daniel Kurtz <djkurtz@chromium. org>
On 07/12/15 09:19, Daniel Kurtz wrote: > Bayi, > > On Mon, Dec 7, 2015 at 12:46 PM, bayi cheng <bayi.cheng@mediatek.com> wrote: >> On Mon, 2015-12-07 at 12:34 +0800, bayi cheng wrote: >>> On Mon, 2015-12-07 at 12:09 +0800, Daniel Kurtz wrote: >>>> Bayi, >>>> >>>> On Mon, Dec 7, 2015 at 11:53 AM, Bayi Cheng <bayi.cheng@mediatek.com> wrote: >>>>> Add Mediatek nor flash node >>>>> >>>>> Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com> >>>>> Acked-by: Brian Norris <computersforpeace@gmail.com> >>>>> --- >>>>> Previous version of this patch is >>>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/386005.html >>>>> Drop flash node from mt8173.dtsi accroding review comment >>>> >>>> Is there a flash on mt8173-evb that can be accessed by the nor_flash ? >>>> If so, can you include flash@0 node in the mt8173-evb.dts. >>>> >>>> -Dan >>>> >>> Hi Daniel, Thanks for your comments! you are right, there is a flash on >>> mt8173-evb which can be accessed by the nor_flash, and I will include >>> flash@0 node in mt8173-evb.dts (kernel v3.18) too. >>> >>> Bayi >> >> Hi Dan, I have reworked a EVB board for spi nor verify, we replaced the >> spi nand flash with spi nor flash on EVB board, >> and our shipping EVB board haven't support spi nor flash, So I will not >> include flash@0 node in the mt8173-evb.dts. I am sorry to made you >> confused! > > Thanks for confirming. > > Reviewed-by: Daniel Kurtz <djkurtz@chromium. org> > Added to v4.5-next/dts Thanks a lot.
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 4dd5f93..af08e97 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi @@ -387,6 +387,17 @@ status = "disabled"; }; + nor_flash: spi@1100d000 { + compatible = "mediatek,mt8173-nor"; + reg = <0 0x1100d000 0 0xe0>; + clocks = <&pericfg CLK_PERI_SPI>, + <&topckgen CLK_TOP_SPINFI_IFR_SEL>; + clock-names = "spi", "sf"; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + }; + i2c3: i2c@11010000 { compatible = "mediatek,mt8173-i2c"; reg = <0 0x11010000 0 0x70>,