| Message ID | E1ZoD3b-0006UD-Rp@rmk-PC.arm.linux.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Oct 19, 2015 at 05:13:07PM +0100, Russell King wrote: > Implement an ARM delay timer to be used for udelay() on orion legacy > platforms. This allows us to skip the delay loop calibration at boot. > > It also means that udelay() will be unaffected by CPU frequency changes > when cpufreq is enabled on these platforms. > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> > --- > This needs to be tested beyond build testing... So what's happening with this change? I see no progress on it. > > arch/arm/plat-orion/time.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/plat-orion/time.c b/arch/arm/plat-orion/time.c > index 8085a8aac812..ffb93db68e9c 100644 > --- a/arch/arm/plat-orion/time.c > +++ b/arch/arm/plat-orion/time.c > @@ -18,6 +18,7 @@ > #include <linux/irq.h> > #include <linux/sched_clock.h> > #include <plat/time.h> > +#include <asm/delay.h> > > /* > * MBus bridge block registers. > @@ -188,6 +189,15 @@ orion_time_set_base(void __iomem *_timer_base) > timer_base = _timer_base; > } > > +static unsigned long orion_delay_timer_read(void) > +{ > + return ~readl(timer_base + TIMER0_VAL_OFF); > +} > + > +static struct delay_timer orion_delay_timer = { > + .read_current_timer = orion_delay_timer_read, > +}; > + > void __init > orion_time_init(void __iomem *_bridge_base, u32 _bridge_timer1_clr_mask, > unsigned int irq, unsigned int tclk) > @@ -202,6 +212,9 @@ orion_time_init(void __iomem *_bridge_base, u32 _bridge_timer1_clr_mask, > > ticks_per_jiffy = (tclk + HZ/2) / HZ; > > + orion_delay_timer.freq = tclk; > + register_current_timer_delay(&orion_delay_timer); > + > /* > * Set scale and timer for sched_clock. > */ > -- > 2.1.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Mon, Dec 07, 2015 at 10:19:14AM +0000, Russell King - ARM Linux wrote: > On Mon, Oct 19, 2015 at 05:13:07PM +0100, Russell King wrote: > > Implement an ARM delay timer to be used for udelay() on orion legacy > > platforms. This allows us to skip the delay loop calibration at boot. > > > > It also means that udelay() will be unaffected by CPU frequency changes > > when cpufreq is enabled on these platforms. > > > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> > > --- > > This needs to be tested beyond build testing... > > So what's happening with this change? I see no progress on it. I said on IRC you had now tested it. Please send a Tested-by: Andrew
On Mon, Dec 07, 2015 at 03:03:09PM +0100, Andrew Lunn wrote: > On Mon, Dec 07, 2015 at 10:19:14AM +0000, Russell King - ARM Linux wrote: > > On Mon, Oct 19, 2015 at 05:13:07PM +0100, Russell King wrote: > > > Implement an ARM delay timer to be used for udelay() on orion legacy > > > platforms. This allows us to skip the delay loop calibration at boot. > > > > > > It also means that udelay() will be unaffected by CPU frequency changes > > > when cpufreq is enabled on these platforms. > > > > > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> > > > --- > > > This needs to be tested beyond build testing... > > > > So what's happening with this change? I see no progress on it. > > I said on IRC you had now tested it. Please send a Tested-by: Sorry, I've totally lost track, I'd forgotten that it gets used on Dove. Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
On Mon, Dec 07, 2015 at 03:00:36PM +0000, Russell King - ARM Linux wrote: > On Mon, Dec 07, 2015 at 03:03:09PM +0100, Andrew Lunn wrote: > > On Mon, Dec 07, 2015 at 10:19:14AM +0000, Russell King - ARM Linux wrote: > > > On Mon, Oct 19, 2015 at 05:13:07PM +0100, Russell King wrote: > > > > Implement an ARM delay timer to be used for udelay() on orion legacy > > > > platforms. This allows us to skip the delay loop calibration at boot. > > > > > > > > It also means that udelay() will be unaffected by CPU frequency changes > > > > when cpufreq is enabled on these platforms. > > > > > > > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> > > > > --- > > > > This needs to be tested beyond build testing... > > > > > > So what's happening with this change? I see no progress on it. > > > > I said on IRC you had now tested it. Please send a Tested-by: > > Sorry, I've totally lost track, I'd forgotten that it gets used on Dove. > > Tested-by: Russell King <rmk+kernel@arm.linux.org.uk> Acked-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hi Russell, On lun., oct. 19 2015, Russell King <rmk+kernel@arm.linux.org.uk> wrote: > Implement an ARM delay timer to be used for udelay() on orion legacy > platforms. This allows us to skip the delay loop calibration at boot. > > It also means that udelay() will be unaffected by CPU frequency changes > when cpufreq is enabled on these platforms. > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Applied on mvebu/drivers with Acked-by tag from Andrew Lunn Thanks, Gregory > --- > This needs to be tested beyond build testing... > > arch/arm/plat-orion/time.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/plat-orion/time.c b/arch/arm/plat-orion/time.c > index 8085a8aac812..ffb93db68e9c 100644 > --- a/arch/arm/plat-orion/time.c > +++ b/arch/arm/plat-orion/time.c > @@ -18,6 +18,7 @@ > #include <linux/irq.h> > #include <linux/sched_clock.h> > #include <plat/time.h> > +#include <asm/delay.h> > > /* > * MBus bridge block registers. > @@ -188,6 +189,15 @@ orion_time_set_base(void __iomem *_timer_base) > timer_base = _timer_base; > } > > +static unsigned long orion_delay_timer_read(void) > +{ > + return ~readl(timer_base + TIMER0_VAL_OFF); > +} > + > +static struct delay_timer orion_delay_timer = { > + .read_current_timer = orion_delay_timer_read, > +}; > + > void __init > orion_time_init(void __iomem *_bridge_base, u32 _bridge_timer1_clr_mask, > unsigned int irq, unsigned int tclk) > @@ -202,6 +212,9 @@ orion_time_init(void __iomem *_bridge_base, u32 _bridge_timer1_clr_mask, > > ticks_per_jiffy = (tclk + HZ/2) / HZ; > > + orion_delay_timer.freq = tclk; > + register_current_timer_delay(&orion_delay_timer); > + > /* > * Set scale and timer for sched_clock. > */ > -- > 2.1.0 >
On Wed, Jan 27, 2016 at 08:58:50AM +0100, Gregory CLEMENT wrote: > Hi Russell, > > On lun., oct. 19 2015, Russell King <rmk+kernel@arm.linux.org.uk> wrote: > > > Implement an ARM delay timer to be used for udelay() on orion legacy > > platforms. This allows us to skip the delay loop calibration at boot. > > > > It also means that udelay() will be unaffected by CPU frequency changes > > when cpufreq is enabled on these platforms. > > > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> > > Applied on mvebu/drivers with Acked-by tag from Andrew Lunn And, I hope, my tested-by which delayed Andrew's ack until December, despite the patch being marked as CFT because I wanted _others_ to test it (which never happened.)
Hi Russell King, On mer., janv. 27 2016, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Wed, Jan 27, 2016 at 08:58:50AM +0100, Gregory CLEMENT wrote: >> Hi Russell, >> >> On lun., oct. 19 2015, Russell King <rmk+kernel@arm.linux.org.uk> wrote: >> >> > Implement an ARM delay timer to be used for udelay() on orion legacy >> > platforms. This allows us to skip the delay loop calibration at boot. >> > >> > It also means that udelay() will be unaffected by CPU frequency changes >> > when cpufreq is enabled on these platforms. >> > >> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> >> >> Applied on mvebu/drivers with Acked-by tag from Andrew Lunn > > And, I hope, my tested-by which delayed Andrew's ack until December, Now yes :) Gregory > despite the patch being marked as CFT because I wanted _others_ to > test it (which never happened.) > > -- > RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net.
diff --git a/arch/arm/plat-orion/time.c b/arch/arm/plat-orion/time.c index 8085a8aac812..ffb93db68e9c 100644 --- a/arch/arm/plat-orion/time.c +++ b/arch/arm/plat-orion/time.c @@ -18,6 +18,7 @@ #include <linux/irq.h> #include <linux/sched_clock.h> #include <plat/time.h> +#include <asm/delay.h> /* * MBus bridge block registers. @@ -188,6 +189,15 @@ orion_time_set_base(void __iomem *_timer_base) timer_base = _timer_base; } +static unsigned long orion_delay_timer_read(void) +{ + return ~readl(timer_base + TIMER0_VAL_OFF); +} + +static struct delay_timer orion_delay_timer = { + .read_current_timer = orion_delay_timer_read, +}; + void __init orion_time_init(void __iomem *_bridge_base, u32 _bridge_timer1_clr_mask, unsigned int irq, unsigned int tclk) @@ -202,6 +212,9 @@ orion_time_init(void __iomem *_bridge_base, u32 _bridge_timer1_clr_mask, ticks_per_jiffy = (tclk + HZ/2) / HZ; + orion_delay_timer.freq = tclk; + register_current_timer_delay(&orion_delay_timer); + /* * Set scale and timer for sched_clock. */
Implement an ARM delay timer to be used for udelay() on orion legacy platforms. This allows us to skip the delay loop calibration at boot. It also means that udelay() will be unaffected by CPU frequency changes when cpufreq is enabled on these platforms. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> --- This needs to be tested beyond build testing... arch/arm/plat-orion/time.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)