diff mbox

video: fbdev: rivafb: unlock chip before probiding EDID

Message ID 1447724295-1954-1-git-send-email-dbaryshkov@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Dmitry Baryshkov Nov. 17, 2015, 1:38 a.m. UTC 
At least NV3 requires for chip to be unlocked before it is possible to
access I2C registers. Without it, it is not possible to read EDID.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 drivers/video/fbdev/riva/fbdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Tomi Valkeinen Dec. 7, 2015, 4:29 p.m. UTC | #1 
On 17/11/15 03:38, Dmitry Eremin-Solenikov wrote:
> At least NV3 requires for chip to be unlocked before it is possible to
> access I2C registers. Without it, it is not possible to read EDID.
> 
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
>  drivers/video/fbdev/riva/fbdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c
> index f1ad274..2ef26ad 100644
> --- a/drivers/video/fbdev/riva/fbdev.c
> +++ b/drivers/video/fbdev/riva/fbdev.c
> @@ -1765,6 +1765,7 @@ static int riva_get_EDID_i2c(struct fb_info *info)
>  	int i;
>  
>  	NVTRACE_ENTER();
> +	par->riva.LockUnlock(&par->riva, 0);
>  	riva_create_i2c_busses(par);
>  	for (i = 0; i < 3; i++) {
>  		if (!par->chan[i].par)
> 

Thanks, applied for 4.5.

 Tomi
diff mbox

Patch

diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c
index f1ad274..2ef26ad 100644
--- a/drivers/video/fbdev/riva/fbdev.c
+++ b/drivers/video/fbdev/riva/fbdev.c
@@ -1765,6 +1765,7 @@  static int riva_get_EDID_i2c(struct fb_info *info)
 	int i;
 
 	NVTRACE_ENTER();
+	par->riva.LockUnlock(&par->riva, 0);
 	riva_create_i2c_busses(par);
 	for (i = 0; i < 3; i++) {
 		if (!par->chan[i].par)