| Message ID | 1449634091-1842-5-git-send-email-cw00.choi@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 09.12.2015 13:07, Chanwoo Choi wrote: > This patch adds the DMC (Dynamic Memory Controller) bus frequency node > which includes the devfreq-events and regulator properties. The bus > frequency support the DVFS (Dynamic Voltage Frequency Scaling) feature > with ondemand governor. > > The devfreq-events (ppmu_dmc0*) can monitor the utilization of DMC bus > on runtime and the buck1_reg (VDD_MIF power line) supplies the power to > the DMC block. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > arch/arm/boot/dts/exynos3250-monk.dts | 6 ++++++ > arch/arm/boot/dts/exynos3250-rinato.dts | 6 ++++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts > index 443a35085846..d982586a6533 100644 > --- a/arch/arm/boot/dts/exynos3250-monk.dts > +++ b/arch/arm/boot/dts/exynos3250-monk.dts > @@ -498,6 +498,12 @@ > }; > }; > > +&bus_dmc { > + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; > + vdd-supply = <&buck1_reg>; > + status = "okay"; > +}; > + > &xusbxti { > clock-frequency = <24000000>; > }; > diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts > index 3e64d5dcdd60..61477943015b 100644 > --- a/arch/arm/boot/dts/exynos3250-rinato.dts > +++ b/arch/arm/boot/dts/exynos3250-rinato.dts > @@ -675,6 +675,12 @@ > }; > }; > > +&bus_dmc { > + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; > + vdd-supply = <&buck1_reg>; > + status = "okay"; > +}; I would prefer to put this in alphabetical order... which could be tricky because the nodes are not entirely sorted. Maybe after the "&adc" node? Anyway the change looks good: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2015? 12? 10? 09:53, Krzysztof Kozlowski wrote: > On 09.12.2015 13:07, Chanwoo Choi wrote: >> This patch adds the DMC (Dynamic Memory Controller) bus frequency node >> which includes the devfreq-events and regulator properties. The bus >> frequency support the DVFS (Dynamic Voltage Frequency Scaling) feature >> with ondemand governor. >> >> The devfreq-events (ppmu_dmc0*) can monitor the utilization of DMC bus >> on runtime and the buck1_reg (VDD_MIF power line) supplies the power to >> the DMC block. >> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> --- >> arch/arm/boot/dts/exynos3250-monk.dts | 6 ++++++ >> arch/arm/boot/dts/exynos3250-rinato.dts | 6 ++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts >> index 443a35085846..d982586a6533 100644 >> --- a/arch/arm/boot/dts/exynos3250-monk.dts >> +++ b/arch/arm/boot/dts/exynos3250-monk.dts >> @@ -498,6 +498,12 @@ >> }; >> }; >> >> +&bus_dmc { >> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; >> + vdd-supply = <&buck1_reg>; >> + status = "okay"; >> +}; >> + >> &xusbxti { >> clock-frequency = <24000000>; >> }; >> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts >> index 3e64d5dcdd60..61477943015b 100644 >> --- a/arch/arm/boot/dts/exynos3250-rinato.dts >> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts >> @@ -675,6 +675,12 @@ >> }; >> }; >> >> +&bus_dmc { >> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; >> + vdd-supply = <&buck1_reg>; >> + status = "okay"; >> +}; > > I would prefer to put this in alphabetical order... which could be > tricky because the nodes are not entirely sorted. Maybe after the "&adc" > node? OK. I'll move it. > > Anyway the change looks good: > > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Thanks for your review. Regards, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts index 443a35085846..d982586a6533 100644 --- a/arch/arm/boot/dts/exynos3250-monk.dts +++ b/arch/arm/boot/dts/exynos3250-monk.dts @@ -498,6 +498,12 @@ }; }; +&bus_dmc { + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; + vdd-supply = <&buck1_reg>; + status = "okay"; +}; + &xusbxti { clock-frequency = <24000000>; }; diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts index 3e64d5dcdd60..61477943015b 100644 --- a/arch/arm/boot/dts/exynos3250-rinato.dts +++ b/arch/arm/boot/dts/exynos3250-rinato.dts @@ -675,6 +675,12 @@ }; }; +&bus_dmc { + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; + vdd-supply = <&buck1_reg>; + status = "okay"; +}; + &xusbxti { clock-frequency = <24000000>; };
This patch adds the DMC (Dynamic Memory Controller) bus frequency node which includes the devfreq-events and regulator properties. The bus frequency support the DVFS (Dynamic Voltage Frequency Scaling) feature with ondemand governor. The devfreq-events (ppmu_dmc0*) can monitor the utilization of DMC bus on runtime and the buck1_reg (VDD_MIF power line) supplies the power to the DMC block. Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- arch/arm/boot/dts/exynos3250-monk.dts | 6 ++++++ arch/arm/boot/dts/exynos3250-rinato.dts | 6 ++++++ 2 files changed, 12 insertions(+)