diff mbox

crypto: asymmetric_keys/signature.c does not need <module.h>

Message ID 1449691528-29040-1-git-send-email-paul.gortmaker@windriver.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show

Commit Message

Paul Gortmaker Dec. 9, 2015, 8:05 p.m. UTC
This file does not contain any modular related function calls.  So get
rid of module.h since it drags in a lot of other headers and adds to
the preprocessing load.  It does export some symbols though, so we'll
need to ensure it has export.h present instead.

Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 crypto/asymmetric_keys/signature.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Herbert Xu Dec. 12, 2015, 5:44 a.m. UTC | #1
On Wed, Dec 09, 2015 at 03:05:28PM -0500, Paul Gortmaker wrote:
> This file does not contain any modular related function calls.  So get
> rid of module.h since it drags in a lot of other headers and adds to
> the preprocessing load.  It does export some symbols though, so we'll
> need to ensure it has export.h present instead.
> 
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Patch applied.  Thanks.
diff mbox

Patch

diff --git a/crypto/asymmetric_keys/signature.c b/crypto/asymmetric_keys/signature.c
index 7525fd183574..da0821eb69fd 100644
--- a/crypto/asymmetric_keys/signature.c
+++ b/crypto/asymmetric_keys/signature.c
@@ -13,7 +13,7 @@ 
 
 #define pr_fmt(fmt) "SIG: "fmt
 #include <keys/asymmetric-subtype.h>
-#include <linux/module.h>
+#include <linux/export.h>
 #include <linux/err.h>
 #include <crypto/public_key.h>
 #include "asymmetric_keys.h"