| Message ID | 20151217122707.GA4267@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Dan, thanks for pointing this out. Reviewed-by: Eric Auger <eric.auger@linaro.org> I add Thomas in CC since the bug also exists in the native driver I think (drivers/net/ethernet/amd/xgbe/drivers/net/ethernet/amd/xgbe /xgbe-dev.c, xgbe_exit function). Best Regards Eric On 12/17/2015 01:27 PM, Dan Carpenter wrote: > This loop ends with count set to -1 and not zero so the warning message > isn't printed when it should be. I've fixed this by change the postop > to a preop. > > Fixes: 0990822c9866 ('VFIO: platform: reset: AMD xgbe reset module') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > index da5356f..d4030d0 100644 > --- a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > +++ b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > @@ -110,7 +110,7 @@ int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev) > usleep_range(10, 15); > > count = 2000; > - while (count-- && (ioread32(xgmac_regs->ioaddr + DMA_MR) & 1)) > + while (--count && (ioread32(xgmac_regs->ioaddr + DMA_MR) & 1)) > usleep_range(500, 600); > > if (!count) > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Dec 17, 2015 at 01:45:52PM +0100, Eric Auger wrote: > I add Thomas in CC since the bug also exists in the native driver I > think (drivers/net/ethernet/amd/xgbe/drivers/net/ethernet/amd/xgbe > /xgbe-dev.c, xgbe_exit function). > Thanks, but I sent a patch for that one already. (These are static checker fixes). regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2015-12-17 at 15:27 +0300, Dan Carpenter wrote: > This loop ends with count set to -1 and not zero so the warning > message > isn't printed when it should be. I've fixed this by change the > postop > to a preop. > > Fixes: 0990822c9866 ('VFIO: platform: reset: AMD xgbe reset module') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied to next for v4.5 with Eric's Reviewed-by. Thanks! Alex > diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > index da5356f..d4030d0 100644 > --- a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > +++ b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > @@ -110,7 +110,7 @@ int vfio_platform_amdxgbe_reset(struct > vfio_platform_device *vdev) > usleep_range(10, 15); > > count = 2000; > - while (count-- && (ioread32(xgmac_regs->ioaddr + DMA_MR) & > 1)) > + while (--count && (ioread32(xgmac_regs->ioaddr + DMA_MR) & > 1)) > usleep_range(500, 600); > > if (!count) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c index da5356f..d4030d0 100644 --- a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c +++ b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c @@ -110,7 +110,7 @@ int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev) usleep_range(10, 15); count = 2000; - while (count-- && (ioread32(xgmac_regs->ioaddr + DMA_MR) & 1)) + while (--count && (ioread32(xgmac_regs->ioaddr + DMA_MR) & 1)) usleep_range(500, 600); if (!count)
This loop ends with count set to -1 and not zero so the warning message isn't printed when it should be. I've fixed this by change the postop to a preop. Fixes: 0990822c9866 ('VFIO: platform: reset: AMD xgbe reset module') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html