| Message ID | 568B98A6.3010908@dev.mellanox.co.il (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
> In ib_mad.h, ib_mad_snoop_handler uses send_buf rather than send_wr
The MAD snooping should be removed from the mad stack. There are no in tree users and the only attempt at adding one was rejected.
On 1/5/2016 12:38 PM, Hefty, Sean wrote: >> In ib_mad.h, ib_mad_snoop_handler uses send_buf rather than send_wr > > The MAD snooping should be removed from the mad stack. This last discussed on linux-rdma list back in late September when Ira posted a partial RFC patch to do this. > There are no in tree users and the only attempt at adding one was rejected. There are no in tree users of this but there is your madeye tool (which is out of tree). This is still a useful debug tool for MADs and there are people who still use that. Ira posted the start of MAD stack tracing but AFAIT it was not equivalent and that thread died out. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > There are no in tree users and the only attempt at adding one was > rejected. > > There are no in tree users of this but there is your madeye tool (which > is out of tree). This is still a useful debug tool for MADs and there > are people who still use that. It's an out of tree tool. Maintain the snooping hooks into the mad layer out of tree as well.
On Tue, Jan 5, 2016 at 9:00 PM, Hefty, Sean <sean.hefty@intel.com> wrote: >> > There are no in tree users and the only attempt at adding one was >> rejected. >> >> There are no in tree users of this but there is your madeye tool (which >> is out of tree). This is still a useful debug tool for MADs and there >> are people who still use that. > > It's an out of tree tool. Maintain the snooping hooks into the mad layer out of tree as well. Any real reason not to pick this good tool into the kernel code? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/rdma/ib_mad.h b/include/rdma/ib_mad.h index ec9b44d..2b3573d 100644 --- a/include/rdma/ib_mad.h +++ b/include/rdma/ib_mad.h @@ -424,11 +424,11 @@ typedef void (*ib_mad_send_handler)(struct ib_mad_agent *mad_agent, /** * ib_mad_snoop_handler - Callback handler for snooping sent MADs. * @mad_agent: MAD agent that snooped the MAD. - * @send_wr: Work request information on the sent MAD. + * @send_buf: send MAD data buffer. * @mad_send_wc: Work completion information on the sent MAD. Valid * only for snooping that occurs on a send completion. * - * Clients snooping MADs should not modify data referenced by the @send_wr + * Clients snooping MADs should not modify data referenced by the @send_buf * or @mad_send_wc. */ typedef void (*ib_mad_snoop_handler)(struct ib_mad_agent *mad_agent,
In ib_mad.h, ib_mad_snoop_handler uses send_buf rather than send_wr Signed-off-by: Hal Rosenstock <hal@mellanox.com> --- Change since v2: Changed title to use "higher" language Change since v1: Fixed typo in patch description -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html