| Message ID | 1452020286-9508-3-git-send-email-pandit.parav@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Wed, Jan 06, 2016 at 12:28:02AM +0530, Parav Pandit wrote: > Added function pointer table to store resource pool specific > operation for each resource type (verb and hw). > Added list node to link device to rdma cgroup so that it can > participate in resource accounting and limit configuration. Is there any point in splitting patches 1 and 2 from 3?
On Wed, Jan 6, 2016 at 3:26 AM, Tejun Heo <tj@kernel.org> wrote: > On Wed, Jan 06, 2016 at 12:28:02AM +0530, Parav Pandit wrote: >> Added function pointer table to store resource pool specific >> operation for each resource type (verb and hw). >> Added list node to link device to rdma cgroup so that it can >> participate in resource accounting and limit configuration. > > Is there any point in splitting patches 1 and 2 from 3? > Patch 2 is in IB stack, so I separated that patch out from 1. That makes it 3 patches. If you think single patch is easier to review, let me know, I can respin to have one patch for these 3 smaller patches. > -- > tejun -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 07, 2016 at 04:46:19AM +0530, Parav Pandit wrote: > On Wed, Jan 6, 2016 at 3:26 AM, Tejun Heo <tj@kernel.org> wrote: > > On Wed, Jan 06, 2016 at 12:28:02AM +0530, Parav Pandit wrote: > >> Added function pointer table to store resource pool specific > >> operation for each resource type (verb and hw). > >> Added list node to link device to rdma cgroup so that it can > >> participate in resource accounting and limit configuration. > > > > Is there any point in splitting patches 1 and 2 from 3? > > > Patch 2 is in IB stack, so I separated that patch out from 1. That > makes it 3 patches. > If you think single patch is easier to review, let me know, I can > respin to have one patch for these 3 smaller patches. They don't do anything by themselves. I think putting them into a single patch would be easier to review. Thanks.
On Thu, Jan 7, 2016 at 8:37 PM, Tejun Heo <tj@kernel.org> wrote: > On Thu, Jan 07, 2016 at 04:46:19AM +0530, Parav Pandit wrote: >> On Wed, Jan 6, 2016 at 3:26 AM, Tejun Heo <tj@kernel.org> wrote: >> > On Wed, Jan 06, 2016 at 12:28:02AM +0530, Parav Pandit wrote: >> >> Added function pointer table to store resource pool specific >> >> operation for each resource type (verb and hw). >> >> Added list node to link device to rdma cgroup so that it can >> >> participate in resource accounting and limit configuration. >> > >> > Is there any point in splitting patches 1 and 2 from 3? >> > >> Patch 2 is in IB stack, so I separated that patch out from 1. That >> makes it 3 patches. >> If you think single patch is easier to review, let me know, I can >> respin to have one patch for these 3 smaller patches. > > They don't do anything by themselves. I think putting them into a > single patch would be easier to review. o.k. I will put them in single patch. > > Thanks. > > -- > tejun -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 9a68a19..1a17249 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -51,6 +51,7 @@ #include <linux/socket.h> #include <uapi/linux/if_ether.h> +#include <linux/cgroup_rdma.h> #include <linux/atomic.h> #include <linux/mmu_notifier.h> #include <asm/uaccess.h> @@ -1823,6 +1824,12 @@ struct ib_device { u8 node_type; u8 phys_port_cnt; +#ifdef CONFIG_CGROUP_RDMA + struct rdmacg_resource_pool_ops + *rpool_ops[RDMACG_RESOURCE_POOL_TYPE_MAX]; + struct list_head rdmacg_list; +#endif + /** * The following mandatory functions are used only at device * registration. Keep functions such as these at the end of this
Added function pointer table to store resource pool specific operation for each resource type (verb and hw). Added list node to link device to rdma cgroup so that it can participate in resource accounting and limit configuration. Signed-off-by: Parav Pandit <pandit.parav@gmail.com> --- include/rdma/ib_verbs.h | 7 +++++++ 1 file changed, 7 insertions(+)