diff mbox

acpi: avoid leaking format string into kobject name

Message ID 20160107192429.GA5113@www.outflux.net (mailing list archive)
State Accepted, archived
Delegated to: Rafael Wysocki
Headers show

Commit Message

Kees Cook Jan. 7, 2016, 7:24 p.m. UTC 
The dn->name is expected to be used as a literal, so add the missing
"%s".

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 drivers/acpi/device_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rafael J. Wysocki Jan. 8, 2016, 12:44 a.m. UTC | #1 
On Thursday, January 07, 2016 11:24:29 AM Kees Cook wrote:
> The dn->name is expected to be used as a literal, so add the missing
> "%s".
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>

Applied, thanks!

> ---
>  drivers/acpi/device_sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
> index 707cf6213bc2..b9afb47db7ed 100644
> --- a/drivers/acpi/device_sysfs.c
> +++ b/drivers/acpi/device_sysfs.c
> @@ -104,7 +104,7 @@ static void acpi_expose_nondev_subnodes(struct kobject *kobj,
>  
>  		init_completion(&dn->kobj_done);
>  		ret = kobject_init_and_add(&dn->kobj, &acpi_data_node_ktype,
> -					   kobj, dn->name);
> +					   kobj, "%s", dn->name);
>  		if (ret)
>  			acpi_handle_err(dn->handle, "Failed to expose (%d)\n", ret);
>  		else
>
diff mbox

Patch

diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 707cf6213bc2..b9afb47db7ed 100644
--- a/drivers/acpi/device_sysfs.c
+++ b/drivers/acpi/device_sysfs.c
@@ -104,7 +104,7 @@  static void acpi_expose_nondev_subnodes(struct kobject *kobj,
 
 		init_completion(&dn->kobj_done);
 		ret = kobject_init_and_add(&dn->kobj, &acpi_data_node_ktype,
-					   kobj, dn->name);
+					   kobj, "%s", dn->name);
 		if (ret)
 			acpi_handle_err(dn->handle, "Failed to expose (%d)\n", ret);
 		else