| Message ID | 1452410557-29208-1-git-send-email-zhengxing@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Xing, Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng: > Because the RK3036 doesn't support EMAC, and only support the RMII mode > in the EMAC IP, we refer to the TRM CRU and update the new external > clock name for EMAC. > > Signed-off-by: Xing Zheng <zhengxing@rock-chips.com> as I said in the other mail, I already fixed the original patch myself :-) So I'm just going to drop this one. Heiko https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
Hi Heiko, > ? 2016?1?10??17:59?Heiko Stuebner <heiko@sntech.de> ??? > > Hi Xing, > > Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng: >> Because the RK3036 doesn't support EMAC, and only support the RMII mode >> in the EMAC IP, we refer to the TRM CRU and update the new external >> clock name for EMAC. >> >> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com> > > as I said in the other mail, I already fixed the original patch myself :-) > So I'm just going to drop this one. > > > Heiko > > https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931 > I am sorry to misunderstand. OK, thank you for your help. :)
Hi Heiko, > ? 2016?1?10??18:29?Xing Zheng <zhengxing@rock-chips.com> ??? > > > Hi Heiko, > >> ? 2016?1?10??17:59?Heiko Stuebner <heiko@sntech.de> ??? >> >> Hi Xing, >> >> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng: >>> Because the RK3036 doesn't support EMAC, and only support the RMII mode >>> in the EMAC IP, we refer to the TRM CRU and update the new external >>> clock name for EMAC. >>> >>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com> >> >> as I said in the other mail, I already fixed the original patch myself :-) >> So I'm just going to drop this one. >> >> >> Heiko >> >> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931 > I am sorry to misunderstand. > > OK, thank you for your help. :) Your patch is: - - "ext_gmac" - external GMAC clock - optional + - "rmii_clkin" - external GMAC clock - optional I think that these should be like this: - - "ext_gmac" - external GMAC clock - optional + - "rmii_clkin" - external EMAC clock - optional Thanks. :)
Am Sonntag, 10. Januar 2016, 18:36:12 schrieb Xing Zheng: > Hi Heiko, > > > ? 2016?1?10??18:29?Xing Zheng <zhengxing@rock-chips.com> ??? > > > > > > Hi Heiko, > > > >> ? 2016?1?10??17:59?Heiko Stuebner <heiko@sntech.de> ??? > >> > >> Hi Xing, > >> > >> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng: > >>> Because the RK3036 doesn't support EMAC, and only support the RMII > >>> mode > >>> in the EMAC IP, we refer to the TRM CRU and update the new external > >>> clock name for EMAC. > >>> > >>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com> > >> > >> as I said in the other mail, I already fixed the original patch myself > >> :-) So I'm just going to drop this one. > >> > >> > >> Heiko > >> > >> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/c > >> ommit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931> > > I am sorry to misunderstand. > > > > OK, thank you for your help. :) > > Your patch is: > - - "ext_gmac" - external GMAC clock - optional > + - "rmii_clkin" - external GMAC clock - optional > > I think that these should be like this: > - - "ext_gmac" - external GMAC clock - optional > + - "rmii_clkin" - external EMAC clock - optional I fixed that up now, thanks for catching this. https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=1c888eb1054a08620a8d2bc5dd2d7cc290897371 Heiko
diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt b/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt index ace0599..20df350 100644 --- a/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt @@ -30,7 +30,7 @@ that they are defined using standard clock bindings with following clock-output-names: - "xin24m" - crystal input - required, - "ext_i2s" - external I2S clock - optional, - - "ext_gmac" - external GMAC clock - optional + - "rmii_clkin" - external EMAC clock - optional Example: Clock controller node:
Because the RK3036 doesn't support EMAC, and only support the RMII mode in the EMAC IP, we refer to the TRM CRU and update the new external clock name for EMAC. Signed-off-by: Xing Zheng <zhengxing@rock-chips.com> --- .../bindings/clock/rockchip,rk3036-cru.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)