diff mbox

[V2,3/3] dt-bindings: bsm2835: fix bindings documentation to use new clock framework

Message ID 1452602149-5875-4-git-send-email-kernel@martin.sperl.org (mailing list archive)
State New, archived
Headers show

Commit Message

Martin Sperl Jan. 12, 2016, 12:35 p.m. UTC 
From: Martin Sperl <kernel@martin.sperl.org>

The bcm2835-i2s driver has been updated to use the new clock framework
for the bcm2835 SOC.

This patch documents the required changes to the bindings.

Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
---
 Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Rob Herring (Arm) Jan. 12, 2016, 2:36 p.m. UTC | #1 
On Tue, Jan 12, 2016 at 12:35:48PM +0000, kernel@martin.sperl.org wrote:
> From: Martin Sperl <kernel@martin.sperl.org>

Typo in the subject (bsm).

> 
> The bcm2835-i2s driver has been updated to use the new clock framework
> for the bcm2835 SOC.
> 
> This patch documents the required changes to the bindings.
> 
> Signed-off-by: Martin Sperl <kernel@martin.sperl.org>

Please add acks when you post new versions.
Martin Sperl Jan. 12, 2016, 3:52 p.m. UTC | #2 
> On 12.01.2016, at 15:36, Rob Herring <robh@kernel.org> wrote:
> 
> On Tue, Jan 12, 2016 at 12:35:48PM +0000, kernel@martin.sperl.org wrote:
>> From: Martin Sperl <kernel@martin.sperl.org>
> 
> Typo in the subject (bsm).
> 
>> 
>> The bcm2835-i2s driver has been updated to use the new clock framework
>> for the bcm2835 SOC.
>> 
>> This patch documents the required changes to the bindings.
>> 
>> Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
> 
> Please add acks when you post new versions.
> 

You want it resent with the typo fixed and signed-off?
Eric Anholt Jan. 28, 2016, 10:11 p.m. UTC | #3 
Martin Sperl <kernel@martin.sperl.org> writes:

>> On 12.01.2016, at 15:36, Rob Herring <robh@kernel.org> wrote:
>> 
>> On Tue, Jan 12, 2016 at 12:35:48PM +0000, kernel@martin.sperl.org wrote:
>>> From: Martin Sperl <kernel@martin.sperl.org>
>> 
>> Typo in the subject (bsm).
>> 
>>> 
>>> The bcm2835-i2s driver has been updated to use the new clock framework
>>> for the bcm2835 SOC.
>>> 
>>> This patch documents the required changes to the bindings.
>>> 
>>> Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
>> 
>> Please add acks when you post new versions.
>> 
>
> You want it resent with the typo fixed and signed-off?

Generally, make sure you apply acks as you get them, so that they don't
get lost.  If you fix the subject and add Rob's ack, it's also:

Acked-by: Eric Anholt <eric@anholt.net>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt b/Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt
index 65783de..b331f26 100644
--- a/Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt
+++ b/Documentation/devicetree/bindings/sound/brcm,bcm2835-i2s.txt
@@ -4,11 +4,10 @@  Required properties:
 - compatible: "brcm,bcm2835-i2s"
 - reg: A list of base address and size entries:
 	* The first entry should cover the PCM registers
-	* The second entry should cover the PCM clock registers
+- clocks: the (PCM) clock to use
 - dmas: List of DMA controller phandle and DMA request line ordered pairs.
 - dma-names: Identifier string for each DMA request line in the dmas property.
   These strings correspond 1:1 with the ordered pairs in dmas.
-
   One of the DMA channels will be responsible for transmission (should be
   named "tx") and one for reception (should be named "rx").
 
@@ -16,8 +15,8 @@  Example:
 
 bcm2835_i2s: i2s@7e203000 {
 	compatible = "brcm,bcm2835-i2s";
-	reg = <0x7e203000 0x20>,
-	      <0x7e101098 0x02>;
+	reg = <0x7e203000 0x24>;
+	clocks = <&clocks BCM2835_CLOCK_PCM>;
 
 	dmas = <&dma 2>,
 	       <&dma 3>;