| Message ID | 20160108181306.4a5a7370f0e3f3daa7c9e285@free.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Fri, Jan 08, 2016 at 06:13:06PM +0100, Jean-Francois Moine wrote: > On Wed, 6 Jan 2016 22:20:46 +0100 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > > As there is no documentation about the DE2 nor about the HDMI which > > > are found in the H3, this driver has been built from Allwiiner's > > > sources. > > > > That's unfortunate :/ > > > > Have you checked in the A64 BSP if there was some useful information? > > Same as the H3: no more information about the display system. Too bad... > > > So, there may be license problems, especially for the file > > > de2_hdmi_h3.c which contains a lot of magic values. > > > > I guess it's the biggest issue with your code right now. What licenses > > issues are we talking about here? > > The documentation about the H3, as the other Allwinner documentations, > starts with: > > This documentation is the original work and copyrighted > property of Allwinner Technology ("Allwinner"). Reproduction in > whole or in part must obtain the written approval of Allwinner > and give clear acknowledgement to the copyright owner. I'm not sure this one is an issue. This datasheet is available publicly, and it's common to have a datasheet with restrictions (or even an NDA). > Then, the DE2 sources contain only: > > All Winner Tech, All Right Reserved. 2014-2015 Copyright (c) > > Eventually, there is no copyright/author/history in the HDMI sources. That one is nasty though :/ It seems to be a GPL violation though, so we have two solutions: A) have a clean room implementation B) Ask allwinner to comply with the license The former doesn't look likely to happen soon... Can you open an issue on this on their linux github repo? Thanks! Maxime
On Mon, 18 Jan 2016 11:18:27 +0100 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > Then, the DE2 sources contain only: > > > > All Winner Tech, All Right Reserved. 2014-2015 Copyright (c) > > > > Eventually, there is no copyright/author/history in the HDMI sources. > > That one is nasty though :/ > > It seems to be a GPL violation though, so we have two solutions: > > A) have a clean room implementation > B) Ask allwinner to comply with the license > > The former doesn't look likely to happen soon... Can you open an issue > on this on their linux github repo? Do you really think that I could have more luck than people of the linux-sunxi or pine64 teams?
On Tue, Jan 19, 2016 at 09:49:07AM +0100, Jean-Francois Moine wrote: > On Mon, 18 Jan 2016 11:18:27 +0100 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > > Then, the DE2 sources contain only: > > > > > > All Winner Tech, All Right Reserved. 2014-2015 Copyright (c) > > > > > > Eventually, there is no copyright/author/history in the HDMI sources. > > > > That one is nasty though :/ > > > > It seems to be a GPL violation though, so we have two solutions: > > > > A) have a clean room implementation > > B) Ask allwinner to comply with the license > > > > The former doesn't look likely to happen soon... Can you open an issue > > on this on their linux github repo? > > Do you really think that I could have more luck than people of the > linux-sunxi or pine64 teams? It did work for a few issues in the past... Maxime
--- /dev/null 1970-01-01 01:00:10.240000002 +0100 +++ Documentation/devicetree/bindings/display/sunxi.txt 2016-01-08 17:48:01.775903901 +0100 @@ -0,0 +1,107 @@ +Allwinner sunxi display subsystem +================================= + +The sunxi display subsystems contain a display controller (DE), +one or two LCD controllers (TCON) and their external interfaces. + +Display controller +================== + +Required properties: + +- compatible: value should be one of the following + "allwinner,sun8i-h3-display-engine" + +- clocks: must include clock specifiers corresponding to entries in the + clock-names property. + +- clock-names: must contain + gate: for DE activation + clock: DE clock + +- resets: phandle to the reset of the device + +- ports: phandle's to the LCD ports + +LCD controller +============== + +Required properties: + +- compatible: value should be one of the following + "allwinner,sun8i-h3-lcd" + +- clocks: must include clock specifiers corresponding to entries in the + clock-names property. + +- clock-names: must contain + gate: for LCD activation + clock: pixel clock + +- resets: phandle to the reset of the device + +- port: port node with endpoint definitions as defined in + Documentation/devicetree/bindings/media/video-interfaces.txt + +HDMI support +============ + +Required properties: + +- compatible: value should be one of the following + "allwinner,sun8i-h3-hdmi" + +- clocks: must include clock specifiers corresponding to entries in the + clock-names property. + +- clock-names: must contain + gate: for HDMI activation + clock: pixel clock + ddc-clock: for the HDMI protocol + +- resets: one or two phandle's to the reset of the device + +- port: port node with endpoint definitions as defined in + Documentation/devicetree/bindings/media/video-interfaces.txt + +Example: + + de: de-controller@01000000 { + compatible = "allwinner,sun8i-h3-display-engine"; + ... + clocks = <&bus_gates 44>, <&de_clk>; + clock-names = "gate", "clock"; + resets = <&bus_rst 44>; + ports = <&lcd0_p>; + }; + + lcd0: lcd-controller@01c0c000 { + compatible = "allwinner,sun8i-h3-lcd"; + ... + clocks = <&bus_gates 35>, <&tcon0_clk>; + clock-names = "gate", "clock"; + resets = <&bus_rst 35>; + #address-cells = <1>; + #size-cells = <0>; + lcd0_p: port { + lcd0_ep: endpoint { + remote-endpoint = <&hdmi_ep>; + }; + }; + }; + + hdmi: hdmi@01ee0000 { + compatible = "allwinner,sun8i-h3-hdmi"; + ... + clocks = <&bus_gates 43>, <&hdmi_clk>, + <&hdmi_slow_clk 31>; + clock-names = "gate", "clock", "ddc-clock"; + resets = <&bus_rst 42>, <&bus_rst 43>; + #address-cells = <1>; + #size-cells = <0>; + port { + hdmi_ep: endpoint { + remote-endpoint = <&lcd0_ep>; + }; + }; + };