| Message ID | 1453213055-35563-4-git-send-email-lakshmis@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jan 19, 2016 at 07:47:34PM +0530, P L Sai Krishna wrote: > This patch adds broken-mmc-highspeed property to the binding > doc for Arasan SDHCI. > > Signed-off-by: P L Sai Krishna <lakshmis@xilinx.com> > --- > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index 2088d9f..5884832 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -20,7 +20,8 @@ Required Properties: > Optional Properties: > - broken-tuning: Indicates tuning broken in Silicon 1.0 of > Zynq Ultrascale+ MPSoC. > - > + - broken-mmc-highspeed: Indicates to force > + the controller to use in standard speed. We already have the inverse of this with "cap-mmc-highspeed". The only potential problem is it will need to be added to existing DTs if you start disabling high speed by default. Maybe that's not an issue for users of the Arasan driver. Otherwise, you should determine this with a more specific compatible string. Rob
Hi, > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: Tuesday, January 19, 2016 10:46 PM > To: Lakshmi Sai Krishna Potthuri > Cc: Michal Simek; Soren Brinkmann; Ulf Hansson; Kevin Hao; Emil P. Lenchak; > Tobias Klauser; Sudeep Holla; Adrian Hunter; Jisheng Zhang; Ivan T. Ivanov; > Scott Branden; Vincent Yang; Haibo Chen; Marek Vasut; > ludovic.desroches@atmel.com; Pawel Moll; Mark Rutland; Ian Campbell; > Kumar Gala; Suman Tripathi; Shawn Lin; devicetree@vger.kernel.org; Harini > Katakam; linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org; > Lakshmi Sai Krishna Potthuri; Anirudha Sarangi; Punnaiah Choudary Kalluri; > linux-arm-kernel@lists.infradead.org > Subject: Re: [LINUX PATCH 4/5] Documentation: mmc: Updated the binding > doc for Arasan SDHCI. > > On Tue, Jan 19, 2016 at 07:47:34PM +0530, P L Sai Krishna wrote: > > This patch adds broken-mmc-highspeed property to the binding doc for > > Arasan SDHCI. > > > > Signed-off-by: P L Sai Krishna <lakshmis@xilinx.com> > > --- <snip> > > - > > + - broken-mmc-highspeed: Indicates to force > > + the controller to use in standard speed. > > We already have the inverse of this with "cap-mmc-highspeed". > > The only potential problem is it will need to be added to existing DTs if you > start disabling high speed by default. Maybe that's not an issue for users of > the Arasan driver. > It might be an issue for other users. I know that it will be an issue for older Xilinx SoC (Zynq), for ex. > Otherwise, you should determine this with a more specific compatible string. > Since this feature might be broken on any SoC, I thought it would be good to provide a dt property. Using a compatibility string will offer no flexibility as per board or silicon. Regards, Harini This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
On Tue, Jan 19, 2016 at 11:51 PM, Lakshmi Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com> wrote: > Hi, > >> -----Original Message----- >> From: Rob Herring [mailto:robh@kernel.org] >> Sent: Tuesday, January 19, 2016 10:46 PM >> To: Lakshmi Sai Krishna Potthuri >> Cc: Michal Simek; Soren Brinkmann; Ulf Hansson; Kevin Hao; Emil P. Lenchak; >> Tobias Klauser; Sudeep Holla; Adrian Hunter; Jisheng Zhang; Ivan T. Ivanov; >> Scott Branden; Vincent Yang; Haibo Chen; Marek Vasut; >> ludovic.desroches@atmel.com; Pawel Moll; Mark Rutland; Ian Campbell; >> Kumar Gala; Suman Tripathi; Shawn Lin; devicetree@vger.kernel.org; Harini >> Katakam; linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org; >> Lakshmi Sai Krishna Potthuri; Anirudha Sarangi; Punnaiah Choudary Kalluri; >> linux-arm-kernel@lists.infradead.org >> Subject: Re: [LINUX PATCH 4/5] Documentation: mmc: Updated the binding >> doc for Arasan SDHCI. >> >> On Tue, Jan 19, 2016 at 07:47:34PM +0530, P L Sai Krishna wrote: >> > This patch adds broken-mmc-highspeed property to the binding doc for >> > Arasan SDHCI. >> > >> > Signed-off-by: P L Sai Krishna <lakshmis@xilinx.com> >> > --- > <snip> >> > - >> > + - broken-mmc-highspeed: Indicates to force >> > + the controller to use in standard speed. >> >> We already have the inverse of this with "cap-mmc-highspeed". >> >> The only potential problem is it will need to be added to existing DTs if you >> start disabling high speed by default. Maybe that's not an issue for users of >> the Arasan driver. >> > > It might be an issue for other users. > I know that it will be an issue for older Xilinx SoC (Zynq), for ex. > >> Otherwise, you should determine this with a more specific compatible string. >> > > Since this feature might be broken on any SoC, I thought it would be > good to provide a dt property. > Using a compatibility string will offer no flexibility as per board or silicon. I've thought about this some more. Since this is an override of the SDHCI capabilities register, I'm okay with this property. However, it should be common to all SDHCI controller and handled in the core SDHCI code. Another way this could be handled is directly provide an override value for the capability register in the DT. Then we don't have to provide a property for every capability bit. Additionally, the Arasan binding needs to have SOC specific compatible strings. IP vendor strings alone have been proven often to be insufficient. Rob
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt index 2088d9f..5884832 100644 --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt @@ -20,7 +20,8 @@ Required Properties: Optional Properties: - broken-tuning: Indicates tuning broken in Silicon 1.0 of Zynq Ultrascale+ MPSoC. - + - broken-mmc-highspeed: Indicates to force + the controller to use in standard speed. Example: sdhci@e0100000 { compatible = "arasan,sdhci-8.9a";
This patch adds broken-mmc-highspeed property to the binding doc for Arasan SDHCI. Signed-off-by: P L Sai Krishna <lakshmis@xilinx.com> --- Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)