| Message ID | 1450975076-7411-2-git-send-email-ivo.g.dimitrov.75@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 24 December 2015 17:37:55 Ivaylo Dimitrov wrote: > So it can be used by code outside arch/arm/kernel/. Fix save_atags() > declaration to match its definition while at it. > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Tested-by: Pali Rohár <pali.rohar@gmail.com>
* Pali Rohár <pali.rohar@gmail.com> [151224 09:48]: > On Thursday 24 December 2015 17:37:55 Ivaylo Dimitrov wrote: > > So it can be used by code outside arch/arm/kernel/. Fix save_atags() > > declaration to match its definition while at it. > > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > > Tested-by: Pali Rohár <pali.rohar@gmail.com> Nice, please upload both to Russell's patch system after no more comments: Acked-by: Tony Lindgren <tony@atomide.com>
On 24.12.2015 20:53, Tony Lindgren wrote: > * Pali Rohár <pali.rohar@gmail.com> [151224 09:48]: >> On Thursday 24 December 2015 17:37:55 Ivaylo Dimitrov wrote: >>> So it can be used by code outside arch/arm/kernel/. Fix save_atags() >>> declaration to match its definition while at it. >>> >>> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> >> >> Tested-by: Pali Rohár <pali.rohar@gmail.com> > > Nice, please upload both to Russell's patch system after no > more comments: > > Acked-by: Tony Lindgren <tony@atomide.com> > Hi Tony, Could you elaborate on that patch system? Where it is and do I need some special account/access? Regards, Ivo
* Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [151224 11:02]: > Could you elaborate on that patch system? Where it is and do I need some > special account/access? Sorry going through my pending mail and only now noticed this one. Looks like you got it figured out though as the patches are in mainline now :) Regards, Tony
diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h index e0adb9f..3613d7e 100644 --- a/arch/arm/include/asm/setup.h +++ b/arch/arm/include/asm/setup.h @@ -25,4 +25,10 @@ extern int arm_add_memory(u64 start, u64 size); extern void early_print(const char *str, ...); extern void dump_machine_table(void); +#ifdef CONFIG_ATAGS_PROC +extern void save_atags(const struct tag *tags); +#else +static inline void save_atags(const struct tag *tags) { } +#endif + #endif diff --git a/arch/arm/kernel/atags.h b/arch/arm/kernel/atags.h index ec4164d..edfa226 100644 --- a/arch/arm/kernel/atags.h +++ b/arch/arm/kernel/atags.h @@ -1,9 +1,3 @@ -#ifdef CONFIG_ATAGS_PROC -extern void save_atags(struct tag *tags); -#else -static inline void save_atags(struct tag *tags) { } -#endif - void convert_to_tag_list(struct tag *tags); #ifdef CONFIG_ATAGS
So it can be used by code outside arch/arm/kernel/. Fix save_atags() declaration to match its definition while at it. Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> --- arch/arm/include/asm/setup.h | 6 ++++++ arch/arm/kernel/atags.h | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-)