| Message ID | 1453727891-24641-1-git-send-email-ian.campbell@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jan 25, Ian Campbell wrote: > We build most of tools using Werror and there seems to be know > deliberate reason for this to be an exception. s/know/no/ ? Acked-by: Olaf Hering <olaf@aepfle.de> Olaf
On Mon, 2016-01-25 at 14:20 +0100, Olaf Hering wrote: > On Mon, Jan 25, Ian Campbell wrote: > > > We build most of tools using Werror and there seems to be know > > deliberate reason for this to be an exception. > > s/know/no/ ? Yes, thanks! I think I was going to write "I don't know of" and then changed my mind not quite all the way. > Acked-by: Olaf Hering <olaf@aepfle.de> Thanks. Ian.
At 13:18 +0000 on 25 Jan (1453727891), Ian Campbell wrote: > We build most of tools using Werror and there seems to be know > deliberate reason for this to be an exception. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Tim Deegan <tim@xen.org>
On Mon, 2016-01-25 at 13:25 +0000, Tim Deegan wrote: > At 13:18 +0000 on 25 Jan (1453727891), Ian Campbell wrote: > > We build most of tools using Werror and there seems to be know > > deliberate reason for this to be an exception. > > > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > Acked-by: Tim Deegan <tim@xen.org> applied, thanks. (FTR, I skipped my usual full set of usual pre-push build tests, since the machines I use are unavailable right now. I have done an x86_64 make dist).
On Mon, Jan 25, Ian Campbell wrote: > We build most of tools using Werror and there seems to be know > deliberate reason for this to be an exception. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> This would have caught the kdd error. Tested-by: Olaf Hering <olaf@aepfle.de> Olaf
diff --git a/tools/debugger/kdd/Makefile b/tools/debugger/kdd/Makefile index 72ad1b9..f3a597d 100644 --- a/tools/debugger/kdd/Makefile +++ b/tools/debugger/kdd/Makefile @@ -1,6 +1,7 @@ XEN_ROOT = $(CURDIR)/../../.. include $(XEN_ROOT)/tools/Rules.mk +CFLAGS += -Werror CFLAGS += $(CFLAGS_libxenctrl) CFLAGS += -DXC_WANT_COMPAT_MAP_FOREIGN_API LDLIBS += $(LDLIBS_libxenctrl)
We build most of tools using Werror and there seems to be know deliberate reason for this to be an exception. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- tools/debugger/kdd/Makefile | 1 + 1 file changed, 1 insertion(+)