| Message ID | 1453335459-3617-2-git-send-email-lho@apm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Wed, Jan 20, 2016 at 4:17 PM, Loc Ho <lho@apm.com> wrote: > > The function acpi_gsi_to_irq must return 0 on success as the caller > ghes_probe expects an 0 for success. This change also matches x86 > implementation. > > Signed-off-by: Tuan Phan <tphan@apm.com> > Signed-off-by: Loc Ho <lho@apm.com> Any issue with this version? If not, can this be pulled into 4.5? -Loc
Loc, On 25/01/16 21:23, Loc Ho wrote: > Hi, > > On Wed, Jan 20, 2016 at 4:17 PM, Loc Ho <lho@apm.com> wrote: >> >> The function acpi_gsi_to_irq must return 0 on success as the caller >> ghes_probe expects an 0 for success. This change also matches x86 >> implementation. >> >> Signed-off-by: Tuan Phan <tphan@apm.com> >> Signed-off-by: Loc Ho <lho@apm.com> > > > Any issue with this version? If not, can this be pulled into 4.5? How is that 4.5 material? Does it fix an observable bug or a regression from a previous? If not, then this is probably to be postponed until 4.6, together with the code that makes use of it. Thanks, M.
Hi Marc, On Tue, Jan 26, 2016 at 12:31 AM, Marc Zyngier <marc.zyngier@arm.com> wrote: > Loc, > > On 25/01/16 21:23, Loc Ho wrote: >> Hi, >> >> On Wed, Jan 20, 2016 at 4:17 PM, Loc Ho <lho@apm.com> wrote: >>> >>> The function acpi_gsi_to_irq must return 0 on success as the caller >>> ghes_probe expects an 0 for success. This change also matches x86 >>> implementation. >>> >>> Signed-off-by: Tuan Phan <tphan@apm.com> >>> Signed-off-by: Loc Ho <lho@apm.com> >> >> >> Any issue with this version? If not, can this be pulled into 4.5? > > How is that 4.5 material? Does it fix an observable bug or a regression > from a previous? If not, then this is probably to be postponed until > 4.6, together with the code that makes use of it. Given that this and the other patch are needed for APEI to work with X-Gene, fine with 4.6. Are we just waiting for Rafael to make the final call then? -Loc
diff --git a/drivers/acpi/gsi.c b/drivers/acpi/gsi.c index ee9e0f2..7b109bd 100644 --- a/drivers/acpi/gsi.c +++ b/drivers/acpi/gsi.c @@ -24,7 +24,7 @@ static struct fwnode_handle *acpi_gsi_domain_id; * * irq location updated with irq value [>0 on success, 0 on failure] * - * Returns: linux IRQ number on success (>0) + * Returns: 0 on success * -EINVAL on failure */ int acpi_gsi_to_irq(u32 gsi, unsigned int *irq) @@ -37,7 +37,7 @@ int acpi_gsi_to_irq(u32 gsi, unsigned int *irq) * *irq == 0 means no mapping, that should * be reported as a failure */ - return (*irq > 0) ? *irq : -EINVAL; + return (*irq > 0) ? 0 : -EINVAL; } EXPORT_SYMBOL_GPL(acpi_gsi_to_irq);