| Message ID | 1453760661-1444-4-git-send-email-richard@nod.at (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On 25/01/2016 22:24, Richard Weinberger wrote: > Not every arch has io or DMA memory. > So, unbreak the build by fixing the dependencies. > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > drivers/scsi/hisi_sas/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig > index 37a0c71..f9157f4 100644 > --- a/drivers/scsi/hisi_sas/Kconfig > +++ b/drivers/scsi/hisi_sas/Kconfig > @@ -2,5 +2,6 @@ config SCSI_HISI_SAS > tristate "HiSilicon SAS" > select SCSI_SAS_LIBSAS > select BLK_DEV_INTEGRITY > + depends on HAS_IOMEM && HAS_DMA > help > This driver supports HiSilicon's SAS HBA > I think that there is already a fix for depencencies from Geert: http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/log/?h=fixes Cheers, John -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 26.01.2016 um 11:15 schrieb John Garry: > On 25/01/2016 22:24, Richard Weinberger wrote: >> Not every arch has io or DMA memory. >> So, unbreak the build by fixing the dependencies. >> >> Signed-off-by: Richard Weinberger <richard@nod.at> >> --- >> drivers/scsi/hisi_sas/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig >> index 37a0c71..f9157f4 100644 >> --- a/drivers/scsi/hisi_sas/Kconfig >> +++ b/drivers/scsi/hisi_sas/Kconfig >> @@ -2,5 +2,6 @@ config SCSI_HISI_SAS >> tristate "HiSilicon SAS" >> select SCSI_SAS_LIBSAS >> select BLK_DEV_INTEGRITY >> + depends on HAS_IOMEM && HAS_DMA >> help >> This driver supports HiSilicon's SAS HBA >> > > I think that there is already a fix for depencencies from Geert: > http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/log/?h=fixes Hmm, right. But we still need HAS_IOMEM too. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 26/01/2016 10:31, Richard Weinberger wrote: > Am 26.01.2016 um 11:15 schrieb John Garry: >> On 25/01/2016 22:24, Richard Weinberger wrote: >>> Not every arch has io or DMA memory. >>> So, unbreak the build by fixing the dependencies. >>> >>> Signed-off-by: Richard Weinberger <richard@nod.at> >>> --- >>> drivers/scsi/hisi_sas/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig >>> index 37a0c71..f9157f4 100644 >>> --- a/drivers/scsi/hisi_sas/Kconfig >>> +++ b/drivers/scsi/hisi_sas/Kconfig >>> @@ -2,5 +2,6 @@ config SCSI_HISI_SAS >>> tristate "HiSilicon SAS" >>> select SCSI_SAS_LIBSAS >>> select BLK_DEV_INTEGRITY >>> + depends on HAS_IOMEM && HAS_DMA >>> help >>> This driver supports HiSilicon's SAS HBA >>> >> >> I think that there is already a fix for depencencies from Geert: >> http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/log/?h=fixes > > Hmm, right. But we still need HAS_IOMEM too. > > Thanks, > //richard > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > We can just add HAS_IOMEM dependency on the scsi fixes branch, ok? Cheers, John -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "John" == John Garry <john.garry@huawei.com> writes:
John> We can just add HAS_IOMEM dependency on the scsi fixes branch, ok?
Yes, please submit a patch against 4.5/scsi-fixes.
diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig index 37a0c71..f9157f4 100644 --- a/drivers/scsi/hisi_sas/Kconfig +++ b/drivers/scsi/hisi_sas/Kconfig @@ -2,5 +2,6 @@ config SCSI_HISI_SAS tristate "HiSilicon SAS" select SCSI_SAS_LIBSAS select BLK_DEV_INTEGRITY + depends on HAS_IOMEM && HAS_DMA help This driver supports HiSilicon's SAS HBA
Not every arch has io or DMA memory. So, unbreak the build by fixing the dependencies. Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/scsi/hisi_sas/Kconfig | 1 + 1 file changed, 1 insertion(+)