| Message ID | 1453889591-30968-2-git-send-email-david@gibson.dropbear.id.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 27.01.2016 11:13, David Gibson wrote: > This stub function is in the !KVM ifdef in target-ppc/kvm_ppc.h. However > no such function exists on the KVM side, or is ever used. > > I think this originally referenced a function which read host page size > information from /proc, for we we now use the KVM GET_SMMU_INFO extension > instead. > > In any case, it has no function now, so remove it. > > Signed-off-by: David Gibson <david@gibson.dropbear.id.au> > --- > target-ppc/kvm_ppc.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h > index 5e1333d..62406ce 100644 > --- a/target-ppc/kvm_ppc.h > +++ b/target-ppc/kvm_ppc.h > @@ -98,11 +98,6 @@ static inline int kvmppc_get_hypercall(CPUPPCState *env, uint8_t *buf, int buf_l > return -1; > } > > -static inline int kvmppc_read_segment_page_sizes(uint32_t *prop, int maxcells) > -{ > - return -1; > -} > - > static inline int kvmppc_set_interrupt(PowerPCCPU *cpu, int irq, int level) > { > return -1; Reviewed-by: Thomas Huth <thuth@redhat.com>
On 27/01/2016 11:13, David Gibson wrote: > This stub function is in the !KVM ifdef in target-ppc/kvm_ppc.h. However > no such function exists on the KVM side, or is ever used. > > I think this originally referenced a function which read host page size > information from /proc, for we we now use the KVM GET_SMMU_INFO extension > instead. > > In any case, it has no function now, so remove it. > > Signed-off-by: David Gibson <david@gibson.dropbear.id.au> > --- > target-ppc/kvm_ppc.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h > index 5e1333d..62406ce 100644 > --- a/target-ppc/kvm_ppc.h > +++ b/target-ppc/kvm_ppc.h > @@ -98,11 +98,6 @@ static inline int kvmppc_get_hypercall(CPUPPCState *env, uint8_t *buf, int buf_l > return -1; > } > > -static inline int kvmppc_read_segment_page_sizes(uint32_t *prop, int maxcells) > -{ > - return -1; > -} > - > static inline int kvmppc_set_interrupt(PowerPCCPU *cpu, int irq, int level) > { > return -1; > Reviewed-by: Laurent Vivier <lvivier@redhat.com> This function has been added by: 4656e1f ppc64: Rudimentary Support for extra page sizes on server CPUs but has never been implemented
diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h index 5e1333d..62406ce 100644 --- a/target-ppc/kvm_ppc.h +++ b/target-ppc/kvm_ppc.h @@ -98,11 +98,6 @@ static inline int kvmppc_get_hypercall(CPUPPCState *env, uint8_t *buf, int buf_l return -1; } -static inline int kvmppc_read_segment_page_sizes(uint32_t *prop, int maxcells) -{ - return -1; -} - static inline int kvmppc_set_interrupt(PowerPCCPU *cpu, int irq, int level) { return -1;
This stub function is in the !KVM ifdef in target-ppc/kvm_ppc.h. However no such function exists on the KVM side, or is ever used. I think this originally referenced a function which read host page size information from /proc, for we we now use the KVM GET_SMMU_INFO extension instead. In any case, it has no function now, so remove it. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> --- target-ppc/kvm_ppc.h | 5 ----- 1 file changed, 5 deletions(-)