| Message ID | 1453816035-3070440-1-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
On Tue, Jan 26, 2016 at 02:47:10PM +0100, Arnd Bergmann wrote: > When building the jitterentropy driver by itself, we get a link error > when CRYPTO_RNG is not enabled as well: > > crypto/built-in.o: In function `jent_mod_init': > jitterentropy-kcapi.c:(.init.text+0x98): undefined reference to `crypto_register_rng' > crypto/built-in.o: In function `jent_mod_exit': > jitterentropy-kcapi.c:(.exit.text+0x60): undefined reference to `crypto_unregister_rng' > > This adds a 'select CRYPTO_RNG' to CRYPTO_JITTERENTROPY to ensure the API > is always there when it's used, not just when DRBG is also enabled. > CRYPTO_DRBG would set it implicitly through CRYPTO_JITTERENTROPY now, > but this leaves it in place to make it explicit what the driver does. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied.
diff --git a/crypto/Kconfig b/crypto/Kconfig index 3be07ad1d80d..88248821af82 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -1595,6 +1595,7 @@ endif # if CRYPTO_DRBG_MENU config CRYPTO_JITTERENTROPY tristate "Jitterentropy Non-Deterministic Random Number Generator" + select CRYPTO_RNG help The Jitterentropy RNG is a noise that is intended to provide seed to another RNG. The RNG does not
When building the jitterentropy driver by itself, we get a link error when CRYPTO_RNG is not enabled as well: crypto/built-in.o: In function `jent_mod_init': jitterentropy-kcapi.c:(.init.text+0x98): undefined reference to `crypto_register_rng' crypto/built-in.o: In function `jent_mod_exit': jitterentropy-kcapi.c:(.exit.text+0x60): undefined reference to `crypto_unregister_rng' This adds a 'select CRYPTO_RNG' to CRYPTO_JITTERENTROPY to ensure the API is always there when it's used, not just when DRBG is also enabled. CRYPTO_DRBG would set it implicitly through CRYPTO_JITTERENTROPY now, but this leaves it in place to make it explicit what the driver does. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- crypto/Kconfig | 1 + 1 file changed, 1 insertion(+)