| Message ID | 1453824219-51437-3-git-send-email-Waiman.Long@hpe.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Waiman Long <Waiman.Long@hpe.com> writes: > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 330e738..443e41d 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -42,6 +42,7 @@ config X86 > select ARCH_SUPPORTS_NUMA_BALANCING if X86_64 > select ARCH_USE_BUILTIN_BSWAP > select ARCH_USE_CMPXCHG_LOCKREF if X86_64 > + select ARCH_USE_LIST_BATCHING if X86_64 I would make it unconditional. The code is simple enough and shouldn't have drawbacks on smaller systems. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 26, 2016 at 01:44:13PM -0800, Andi Kleen wrote: > Waiman Long <Waiman.Long@hpe.com> writes: > > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > > index 330e738..443e41d 100644 > > --- a/arch/x86/Kconfig > > +++ b/arch/x86/Kconfig > > @@ -42,6 +42,7 @@ config X86 > > select ARCH_SUPPORTS_NUMA_BALANCING if X86_64 > > select ARCH_USE_BUILTIN_BSWAP > > select ARCH_USE_CMPXCHG_LOCKREF if X86_64 > > + select ARCH_USE_LIST_BATCHING if X86_64 > > I would make it unconditional. The code is simple enough > and shouldn't have drawbacks on smaller systems. I agree with the sentiment but would like to see a benchmark done on a small system to verify all the same. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/26/2016 04:44 PM, Andi Kleen wrote: > Waiman Long<Waiman.Long@hpe.com> writes: >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >> index 330e738..443e41d 100644 >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig >> @@ -42,6 +42,7 @@ config X86 >> select ARCH_SUPPORTS_NUMA_BALANCING if X86_64 >> select ARCH_USE_BUILTIN_BSWAP >> select ARCH_USE_CMPXCHG_LOCKREF if X86_64 >> + select ARCH_USE_LIST_BATCHING if X86_64 > I would make it unconditional. The code is simple enough > and shouldn't have drawbacks on smaller systems. > > -Andi You are probably right. I will look into that. Cheers, Longman -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 330e738..443e41d 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -42,6 +42,7 @@ config X86 select ARCH_SUPPORTS_NUMA_BALANCING if X86_64 select ARCH_USE_BUILTIN_BSWAP select ARCH_USE_CMPXCHG_LOCKREF if X86_64 + select ARCH_USE_LIST_BATCHING if X86_64 select ARCH_USE_QUEUED_RWLOCKS select ARCH_USE_QUEUED_SPINLOCKS select ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH if SMP
System with a large number of CPUs will benefit from the list batching facility. This patch enables it for x86-64 as 32-bit i386 is not likely to get much gain from it. Signed-off-by: Waiman Long <Waiman.Long@hpe.com> --- arch/x86/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)