| Message ID | E1aOWdF-00058a-0X@rmk-PC.arm.linux.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 27, 2016 at 6:24 PM, Russell King <rmk+kernel@arm.linux.org.uk> wrote: > PCIe reset signals are active low, and our GPIO for this is directly > connected to the PCIe reset. However, as the PCIe driver does not use > the flag, the specification of '0' flags (which means active high) has > not been noticed. Correct this oversight, and switch to using the Yes, the mx6 pci driver did not use the flag, but it does now since 5c5fb40de8f1 ("PCI: imx6: Add support for active-low reset GPIO"), so it would be better to adjust the commit log. Apart from that, patch looks good.
On Wed, Jan 27, 2016 at 07:07:38PM -0200, Fabio Estevam wrote: > On Wed, Jan 27, 2016 at 6:24 PM, Russell King > <rmk+kernel@arm.linux.org.uk> wrote: > > PCIe reset signals are active low, and our GPIO for this is directly > > connected to the PCIe reset. However, as the PCIe driver does not use > > the flag, the specification of '0' flags (which means active high) has > > not been noticed. Correct this oversight, and switch to using the > > Yes, the mx6 pci driver did not use the flag, but it does now since 5c5fb40de8f1 > ("PCI: imx6: Add support for active-low reset GPIO"), so it would be > better to adjust the commit log. I updated the commit log a bit and applied the series. Shawn
diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi index 3a06516fe7a9..258107246d64 100644 --- a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi +++ b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi @@ -253,7 +253,7 @@ &pcie { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_hummingboard_pcie_reset>; - reset-gpio = <&gpio3 4 0>; + reset-gpio = <&gpio3 4 GPIO_ACTIVE_LOW>; status = "okay"; };
PCIe reset signals are active low, and our GPIO for this is directly connected to the PCIe reset. However, as the PCIe driver does not use the flag, the specification of '0' flags (which means active high) has not been noticed. Correct this oversight, and switch to using the GPIO flag definitions instead. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> --- arch/arm/boot/dts/imx6qdl-hummingboard.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)