| Message ID | c1252a1287c86a763b72458e3d8619c23b5d0eaf.1454067262.git.mchehab@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Mauro, On 01/29/2016 09:11 AM, Mauro Carvalho Chehab wrote: > The tvp5150 is an analog TV decoder. Identify as such at > the media graph, or otherwise devices using it would fail. > > That avoids the following warning: > [ 1546.669139] usb 2-3.3: Entity type for entity tvp5150 5-005c was not initialized! > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > --- > drivers/media/i2c/tvp5150.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c > index 20428f052506..19b52736b24e 100644 > --- a/drivers/media/i2c/tvp5150.c > +++ b/drivers/media/i2c/tvp5150.c > @@ -1319,6 +1319,9 @@ static int tvp5150_probe(struct i2c_client *c, > core->pads[DEMOD_PAD_IF_INPUT].flags = MEDIA_PAD_FL_SINK; > core->pads[DEMOD_PAD_VID_OUT].flags = MEDIA_PAD_FL_SOURCE; > core->pads[DEMOD_PAD_VBI_OUT].flags = MEDIA_PAD_FL_SOURCE; > + > + sd->entity.function = MEDIA_ENT_F_ATV_DECODER; > + > res = media_entity_pads_init(&sd->entity, DEMOD_NUM_PADS, core->pads); > if (res < 0) > return res; > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c index 20428f052506..19b52736b24e 100644 --- a/drivers/media/i2c/tvp5150.c +++ b/drivers/media/i2c/tvp5150.c @@ -1319,6 +1319,9 @@ static int tvp5150_probe(struct i2c_client *c, core->pads[DEMOD_PAD_IF_INPUT].flags = MEDIA_PAD_FL_SINK; core->pads[DEMOD_PAD_VID_OUT].flags = MEDIA_PAD_FL_SOURCE; core->pads[DEMOD_PAD_VBI_OUT].flags = MEDIA_PAD_FL_SOURCE; + + sd->entity.function = MEDIA_ENT_F_ATV_DECODER; + res = media_entity_pads_init(&sd->entity, DEMOD_NUM_PADS, core->pads); if (res < 0) return res;
The tvp5150 is an analog TV decoder. Identify as such at the media graph, or otherwise devices using it would fail. That avoids the following warning: [ 1546.669139] usb 2-3.3: Entity type for entity tvp5150 5-005c was not initialized! Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> --- drivers/media/i2c/tvp5150.c | 3 +++ 1 file changed, 3 insertions(+)