| Message ID | 1453901700-20418-1-git-send-email-alex.hung@canonical.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Wed, Jan 27, 2016 at 09:35:00PM +0800, Alex Hung wrote: > intel_hid_keymap contains a duplicate entry for KEY_HOME and an > incorrect HID index for KEY_PAGEDOWN > > Reported-by: Pavel Bludov <pbludov@gmail.com> > Signed-off-by: Alex Hung <alex.hung@canonical.com> Thanks Alex, queued for 4.5 fixes. > --- > drivers/platform/x86/intel-hid.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c > index 20f0ad9..e20f23e 100644 > --- a/drivers/platform/x86/intel-hid.c > +++ b/drivers/platform/x86/intel-hid.c > @@ -41,8 +41,7 @@ static const struct key_entry intel_hid_keymap[] = { > { KE_KEY, 4, { KEY_HOME } }, > { KE_KEY, 5, { KEY_END } }, > { KE_KEY, 6, { KEY_PAGEUP } }, > - { KE_KEY, 4, { KEY_PAGEDOWN } }, > - { KE_KEY, 4, { KEY_HOME } }, > + { KE_KEY, 7, { KEY_PAGEDOWN } }, > { KE_KEY, 8, { KEY_RFKILL } }, > { KE_KEY, 9, { KEY_POWER } }, > { KE_KEY, 11, { KEY_SLEEP } }, > -- > 2.5.0 > >
diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c index 20f0ad9..e20f23e 100644 --- a/drivers/platform/x86/intel-hid.c +++ b/drivers/platform/x86/intel-hid.c @@ -41,8 +41,7 @@ static const struct key_entry intel_hid_keymap[] = { { KE_KEY, 4, { KEY_HOME } }, { KE_KEY, 5, { KEY_END } }, { KE_KEY, 6, { KEY_PAGEUP } }, - { KE_KEY, 4, { KEY_PAGEDOWN } }, - { KE_KEY, 4, { KEY_HOME } }, + { KE_KEY, 7, { KEY_PAGEDOWN } }, { KE_KEY, 8, { KEY_RFKILL } }, { KE_KEY, 9, { KEY_POWER } }, { KE_KEY, 11, { KEY_SLEEP } },
intel_hid_keymap contains a duplicate entry for KEY_HOME and an incorrect HID index for KEY_PAGEDOWN Reported-by: Pavel Bludov <pbludov@gmail.com> Signed-off-by: Alex Hung <alex.hung@canonical.com> --- drivers/platform/x86/intel-hid.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)