diff mbox

arm64: dts: r8a7795: Add USB-DMAC device nodes

Message ID 1454322540-5608-1-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive)
State Accepted
Commit 652a4306be7684d4009e83f5028b3147c6f1c735
Headers show

Commit Message

Yoshihiro Shimoda Feb. 1, 2016, 10:29 a.m. UTC
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
This patch is based on the latest renesas.git / renesas-devel-20160129-v4.5-rc1
tag. (commit id = 0319e29efd838de5a7a4b589b8f07d9c1fd4abf6)

This patch needs r8a7795-cpg-mssr.c update for usb-dmac clocks.

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Comments

Geert Uytterhoeven Feb. 1, 2016, 10:45 a.m. UTC | #1
On Mon, Feb 1, 2016 at 11:29 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Simon Horman Feb. 2, 2016, 9:50 a.m. UTC | #2
On Mon, Feb 01, 2016 at 07:29:00PM +0900, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> This patch is based on the latest renesas.git / renesas-devel-20160129-v4.5-rc1
> tag. (commit id = 0319e29efd838de5a7a4b589b8f07d9c1fd4abf6)
> 
> This patch needs r8a7795-cpg-mssr.c update for usb-dmac clocks.

Thanks, I have queued this up.
Geert Uytterhoeven Feb. 2, 2016, 10:10 a.m. UTC | #3
On Mon, Feb 1, 2016 at 11:29 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -880,5 +880,31 @@
>                         power-domains = <&cpg>;
>                         status = "disabled";
>                 };
> +
> +               usb_dmac0: dma-controller@e65a0000 {
> +                       compatible = "renesas,r8a7795-usb-dmac",
> +                                    "renesas,usb-dmac";
> +                       reg = <0 0xe65a0000 0 0x100>;
> +                       interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH
> +                                     0 109 IRQ_TYPE_LEVEL_HIGH>;

Sorry, I missed you're not using the GIC_SPI defines.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Yoshihiro Shimoda Feb. 2, 2016, 10:22 a.m. UTC | #4
Hi Geert-san, Simon-san,

> From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Geert

> Uytterhoeven

> Sent: Tuesday, February 02, 2016 7:10 PM

> 

> On Mon, Feb 1, 2016 at 11:29 AM, Yoshihiro Shimoda

> <yoshihiro.shimoda.uh@renesas.com> wrote:

> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi

> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi

> > @@ -880,5 +880,31 @@

> >                         power-domains = <&cpg>;

> >                         status = "disabled";

> >                 };

> > +

> > +               usb_dmac0: dma-controller@e65a0000 {

> > +                       compatible = "renesas,r8a7795-usb-dmac",

> > +                                    "renesas,usb-dmac";

> > +                       reg = <0 0xe65a0000 0 0x100>;

> > +                       interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH

> > +                                     0 109 IRQ_TYPE_LEVEL_HIGH>;

> 

> Sorry, I missed you're not using the GIC_SPI defines.


Oops! Thank you for the point.

Simon-san, 
Would you revert this patch? I will submit v2 patch soon.

Best regards,
Yoshihiro Shimoda

> Gr{oetje,eeting}s,

> 

>                         Geert

> 

> --

> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

> 

> In personal conversations with technical people, I call myself a hacker. But

> when I'm talking to journalists I just say "programmer" or something like that.

>                                 -- Linus Torvalds
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 119549e..8cb1838 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -880,5 +880,31 @@ 
 			power-domains = <&cpg>;
 			status = "disabled";
 		};
+
+		usb_dmac0: dma-controller@e65a0000 {
+			compatible = "renesas,r8a7795-usb-dmac",
+				     "renesas,usb-dmac";
+			reg = <0 0xe65a0000 0 0x100>;
+			interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH
+				      0 109 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch0", "ch1";
+			clocks = <&cpg CPG_MOD 330>;
+			power-domains = <&cpg>;
+			#dma-cells = <1>;
+			dma-channels = <2>;
+		};
+
+		usb_dmac1: dma-controller@e65b0000 {
+			compatible = "renesas,r8a7795-usb-dmac",
+				     "renesas,usb-dmac";
+			reg = <0 0xe65b0000 0 0x100>;
+			interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH
+				      0 110 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch0", "ch1";
+			clocks = <&cpg CPG_MOD 331>;
+			power-domains = <&cpg>;
+			#dma-cells = <1>;
+			dma-channels = <2>;
+		};
 	};
 };