| Message ID | 1452948530-10639-1-git-send-email-andreas@kemnade.info (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/16/2016 06:18 PM, Andreas Kemnade wrote: > hdq_usecount was set to zero after a successful read, so > omap_hdq_put could not properly free resources which leads > e.g. to increasing usecounts in lsmod output > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- Reviewed-by: Vignesh R <vigneshr@ti.com> Thanks, > drivers/w1/masters/omap_hdq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c > index 0e2f43b..a2eec97 100644 > --- a/drivers/w1/masters/omap_hdq.c > +++ b/drivers/w1/masters/omap_hdq.c > @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq) > > hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS, > ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK); > - hdq_data->hdq_usecount = 0; > > /* Write followed by a read, release the module */ > if (hdq_data->init_trans) { >
Hi Andreas From w1 perspective this doesn't break things :) Greg, please pull it into your tree if no one objects. Acked-by: Evgeniy Polyakov <zbr@ioremap.net> 16.01.2016, 15:48, "Andreas Kemnade" <andreas@kemnade.info>: > hdq_usecount was set to zero after a successful read, so > omap_hdq_put could not properly free resources which leads > e.g. to increasing usecounts in lsmod output > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > drivers/w1/masters/omap_hdq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c > index 0e2f43b..a2eec97 100644 > --- a/drivers/w1/masters/omap_hdq.c > +++ b/drivers/w1/masters/omap_hdq.c > @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq) > > hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS, > ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK); > - hdq_data->hdq_usecount = 0; > > /* Write followed by a read, release the module */ > if (hdq_data->init_trans) { > -- > 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 19, 2016 at 07:38:28PM +0300, Evgeniy Polyakov wrote: > Hi Andreas > > >From w1 perspective this doesn't break things :) > Greg, please pull it into your tree if no one objects. > > Acked-by: Evgeniy Polyakov <zbr@ioremap.net> Thanks, will do after 4.5-rc1 is out. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
ping... On Tue, 19 Jan 2016 10:13:04 -0800 "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> wrote: > On Tue, Jan 19, 2016 at 07:38:28PM +0300, Evgeniy Polyakov wrote: > > Hi Andreas > > > > >From w1 perspective this doesn't break things :) > > Greg, please pull it into your tree if no one objects. > > > > Acked-by: Evgeniy Polyakov <zbr@ioremap.net> > > Thanks, will do after 4.5-rc1 is out. > > greg k-h > >
diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c index 0e2f43b..a2eec97 100644 --- a/drivers/w1/masters/omap_hdq.c +++ b/drivers/w1/masters/omap_hdq.c @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq) hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS, ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK); - hdq_data->hdq_usecount = 0; /* Write followed by a read, release the module */ if (hdq_data->init_trans) {
hdq_usecount was set to zero after a successful read, so omap_hdq_put could not properly free resources which leads e.g. to increasing usecounts in lsmod output Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- drivers/w1/masters/omap_hdq.c | 1 - 1 file changed, 1 deletion(-)