| Message ID | 1454854455-20894-1-git-send-email-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Feb 7 2016 23:14, Geert Uytterhoeven wrote: > sound/firewire/digi00x/amdtp-dot.c:67: warning: type qualifiers ignored on function return type > > Drop the bogus "const" type qualifier on the return type of dot_scrt() > to fix this. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Yep. It came from original code[1] and I overlooked. Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> > --- > sound/firewire/digi00x/amdtp-dot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/firewire/digi00x/amdtp-dot.c b/sound/firewire/digi00x/amdtp-dot.c > index b02a5e8cad448c40..0ac92aba5bc1c9a4 100644 > --- a/sound/firewire/digi00x/amdtp-dot.c > +++ b/sound/firewire/digi00x/amdtp-dot.c > @@ -63,7 +63,7 @@ struct amdtp_dot { > #define BYTE_PER_SAMPLE (4) > #define MAGIC_DOT_BYTE (2) > #define MAGIC_BYTE_OFF(x) (((x) * BYTE_PER_SAMPLE) + MAGIC_DOT_BYTE) > -static const u8 dot_scrt(const u8 idx, const unsigned int off) > +static u8 dot_scrt(const u8 idx, const unsigned int off) > { > /* > * the length of the added pattern only depends on the lower nibble Thanks [1] https://github.com/x42/003amdtp Takashi Sakamoto
On Sun, 07 Feb 2016 15:14:15 +0100, Geert Uytterhoeven wrote: > > sound/firewire/digi00x/amdtp-dot.c:67: warning: type qualifiers ignored on function return type > > Drop the bogus "const" type qualifier on the return type of dot_scrt() > to fix this. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Applied now, thanks. Takashi > --- > sound/firewire/digi00x/amdtp-dot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/firewire/digi00x/amdtp-dot.c b/sound/firewire/digi00x/amdtp-dot.c > index b02a5e8cad448c40..0ac92aba5bc1c9a4 100644 > --- a/sound/firewire/digi00x/amdtp-dot.c > +++ b/sound/firewire/digi00x/amdtp-dot.c > @@ -63,7 +63,7 @@ struct amdtp_dot { > #define BYTE_PER_SAMPLE (4) > #define MAGIC_DOT_BYTE (2) > #define MAGIC_BYTE_OFF(x) (((x) * BYTE_PER_SAMPLE) + MAGIC_DOT_BYTE) > -static const u8 dot_scrt(const u8 idx, const unsigned int off) > +static u8 dot_scrt(const u8 idx, const unsigned int off) > { > /* > * the length of the added pattern only depends on the lower nibble > -- > 1.9.1 > >
diff --git a/sound/firewire/digi00x/amdtp-dot.c b/sound/firewire/digi00x/amdtp-dot.c index b02a5e8cad448c40..0ac92aba5bc1c9a4 100644 --- a/sound/firewire/digi00x/amdtp-dot.c +++ b/sound/firewire/digi00x/amdtp-dot.c @@ -63,7 +63,7 @@ struct amdtp_dot { #define BYTE_PER_SAMPLE (4) #define MAGIC_DOT_BYTE (2) #define MAGIC_BYTE_OFF(x) (((x) * BYTE_PER_SAMPLE) + MAGIC_DOT_BYTE) -static const u8 dot_scrt(const u8 idx, const unsigned int off) +static u8 dot_scrt(const u8 idx, const unsigned int off) { /* * the length of the added pattern only depends on the lower nibble
sound/firewire/digi00x/amdtp-dot.c:67: warning: type qualifiers ignored on function return type Drop the bogus "const" type qualifier on the return type of dot_scrt() to fix this. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- sound/firewire/digi00x/amdtp-dot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)