| Message ID | 1454924705-8382-1-git-send-email-j-keerthy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote: > The thermal threholds for am57xx are different from that of dra7. > Correcting the thresholds for the same. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > > Depends on: https://lkml.org/lkml/2016/2/8/90 > > arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts > =================================================================== > --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.514959101 +0530 > +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.510959168 +0530 Sorry, did not bother to check, but is this the only user of am57xx? Apart from the above: Acked-by: Eduardo Valentin <edubezval@gmail.com> > @@ -825,3 +825,27 @@ > status = "okay"; > }; > }; > + > +&cpu_alert0 { > + temperature = <90000>; /* milliCelsius */ > +}; > + > +&cpu_crit { > + temperature = <105000>; /* milliCelsius */ > +}; > + > +&gpu_crit { > + temperature = <105000>; /* milliCelsius */ > +}; > + > +&core_crit { > + temperature = <105000>; /* milliCelsius */ > +}; > + > +&dspeve_crit { > + temperature = <105000>; /* milliCelsius */ > +}; > + > +&iva_crit { > + temperature = <105000>; /* milliCelsius */ > +};
On 02/09/2016 04:09 PM, Eduardo Valentin wrote: > On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote: >> The thermal threholds for am57xx are different from that of dra7. >> Correcting the thresholds for the same. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> >> Depends on: https://lkml.org/lkml/2016/2/8/90 >> >> arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts >> =================================================================== >> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.514959101 +0530 >> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.510959168 +0530 > > Sorry, did not bother to check, but is this the only user of am57xx? we will have AM57xx-IDK as well coming down the line. we already have arch/arm/boot/dts/am57xx-cl-som-am57x.dts arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of silicon are used in cl-SOM and sbc boards.
* Nishanth Menon <nm@ti.com> [160209 14:17]: > On 02/09/2016 04:09 PM, Eduardo Valentin wrote: > > On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote: > >> The thermal threholds for am57xx are different from that of dra7. > >> Correcting the thresholds for the same. > >> > >> Signed-off-by: Keerthy <j-keerthy@ti.com> > >> --- > >> > >> Depends on: https://lkml.org/lkml/2016/2/8/90 > >> > >> arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++ > >> 1 file changed, 24 insertions(+) > >> > >> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts > >> =================================================================== > >> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.514959101 +0530 > >> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.510959168 +0530 > > > > Sorry, did not bother to check, but is this the only user of am57xx? > > we will have AM57xx-IDK as well coming down the line. we already have > arch/arm/boot/dts/am57xx-cl-som-am57x.dts > arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of > silicon are used in cl-SOM and sbc boards. Hmm can this one wait for v4.6 or is it critical for v4.5-rc cycle? Regards, Tony
On Fri, Feb 12, 2016 at 4:23 PM, Tony Lindgren <tony@atomide.com> wrote: > * Nishanth Menon <nm@ti.com> [160209 14:17]: >> On 02/09/2016 04:09 PM, Eduardo Valentin wrote: >> > On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote: >> >> The thermal threholds for am57xx are different from that of dra7. >> >> Correcting the thresholds for the same. >> >> >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> >> --- >> >> >> >> Depends on: https://lkml.org/lkml/2016/2/8/90 >> >> >> >> arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++ >> >> 1 file changed, 24 insertions(+) >> >> >> >> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts >> >> =================================================================== >> >> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.514959101 +0530 >> >> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.510959168 +0530 >> > >> > Sorry, did not bother to check, but is this the only user of am57xx? >> >> we will have AM57xx-IDK as well coming down the line. we already have >> arch/arm/boot/dts/am57xx-cl-som-am57x.dts >> arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of >> silicon are used in cl-SOM and sbc boards. > > Hmm can this one wait for v4.6 or is it critical for v4.5-rc > cycle? personally, I'd like to NAK this patch -> lack of reference documentation, and guidance for various AM57xx boards in a generic patch should probably be followed IMHO. --- Regards, Nishanth Menon
* Nishanth Menon <nm@ti.com> [160212 14:32]: > On Fri, Feb 12, 2016 at 4:23 PM, Tony Lindgren <tony@atomide.com> wrote: > > * Nishanth Menon <nm@ti.com> [160209 14:17]: > >> On 02/09/2016 04:09 PM, Eduardo Valentin wrote: > >> > On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote: > >> >> The thermal threholds for am57xx are different from that of dra7. > >> >> Correcting the thresholds for the same. > >> >> > >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> > >> >> --- > >> >> > >> >> Depends on: https://lkml.org/lkml/2016/2/8/90 > >> >> > >> >> arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++ > >> >> 1 file changed, 24 insertions(+) > >> >> > >> >> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts > >> >> =================================================================== > >> >> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.514959101 +0530 > >> >> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.510959168 +0530 > >> > > >> > Sorry, did not bother to check, but is this the only user of am57xx? > >> > >> we will have AM57xx-IDK as well coming down the line. we already have > >> arch/arm/boot/dts/am57xx-cl-som-am57x.dts > >> arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of > >> silicon are used in cl-SOM and sbc boards. > > > > Hmm can this one wait for v4.6 or is it critical for v4.5-rc > > cycle? > > personally, I'd like to NAK this patch -> lack of reference > documentation, and guidance for various AM57xx boards in a generic > patch should probably be followed IMHO. OK let's wait for that then. Regards, Tony
On Saturday 13 February 2016 04:11 AM, Tony Lindgren wrote: > * Nishanth Menon <nm@ti.com> [160212 14:32]: >> On Fri, Feb 12, 2016 at 4:23 PM, Tony Lindgren <tony@atomide.com> wrote: >>> * Nishanth Menon <nm@ti.com> [160209 14:17]: >>>> On 02/09/2016 04:09 PM, Eduardo Valentin wrote: >>>>> On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote: >>>>>> The thermal threholds for am57xx are different from that of dra7. >>>>>> Correcting the thresholds for the same. >>>>>> >>>>>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>>>>> --- >>>>>> >>>>>> Depends on: https://lkml.org/lkml/2016/2/8/90 >>>>>> >>>>>> arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++ >>>>>> 1 file changed, 24 insertions(+) >>>>>> >>>>>> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts >>>>>> =================================================================== >>>>>> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.514959101 +0530 >>>>>> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.510959168 +0530 >>>>> >>>>> Sorry, did not bother to check, but is this the only user of am57xx? >>>> >>>> we will have AM57xx-IDK as well coming down the line. we already have >>>> arch/arm/boot/dts/am57xx-cl-som-am57x.dts >>>> arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of >>>> silicon are used in cl-SOM and sbc boards. >>> >>> Hmm can this one wait for v4.6 or is it critical for v4.5-rc >>> cycle? >> >> personally, I'd like to NAK this patch -> lack of reference >> documentation, and guidance for various AM57xx boards in a generic >> patch should probably be followed IMHO. > > OK let's wait for that then. OK. I will send a v2 with better documentation. > > Regards, > > Tony >
On 02/14/2016 10:27 PM, Keerthy wrote: > > > On Saturday 13 February 2016 04:11 AM, Tony Lindgren wrote: >> * Nishanth Menon <nm@ti.com> [160212 14:32]: >>> On Fri, Feb 12, 2016 at 4:23 PM, Tony Lindgren <tony@atomide.com> wrote: >>>> * Nishanth Menon <nm@ti.com> [160209 14:17]: >>>>> On 02/09/2016 04:09 PM, Eduardo Valentin wrote: >>>>>> On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote: >>>>>>> The thermal threholds for am57xx are different from that of dra7. >>>>>>> Correcting the thresholds for the same. >>>>>>> >>>>>>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>>>>>> --- >>>>>>> >>>>>>> Depends on: https://lkml.org/lkml/2016/2/8/90 >>>>>>> >>>>>>> arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++ >>>>>>> 1 file changed, 24 insertions(+) >>>>>>> >>>>>>> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts >>>>>>> =================================================================== >>>>>>> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.514959101 +0530 >>>>>>> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.510959168 +0530 >>>>>> >>>>>> Sorry, did not bother to check, but is this the only user of am57xx? >>>>> >>>>> we will have AM57xx-IDK as well coming down the line. we already have >>>>> arch/arm/boot/dts/am57xx-cl-som-am57x.dts >>>>> arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of >>>>> silicon are used in cl-SOM and sbc boards. >>>> >>>> Hmm can this one wait for v4.6 or is it critical for v4.5-rc >>>> cycle? >>> >>> personally, I'd like to NAK this patch -> lack of reference >>> documentation, and guidance for various AM57xx boards in a generic >>> patch should probably be followed IMHO. >> >> OK let's wait for that then. > > OK. I will send a v2 with better documentation. This data is in the AM572x datasheet: http://www.ti.com/lit/ds/symlink/am5728.pdf Table 5-3 in the current version contains the maximum junction temperatures. this indicates that there are "Commercial" and "extended" -> we may need to introduce just 2 dtsis -> am57xx-commercial and am57xx-extended and reuse those based on the part on the board. just a suggestion..
On Monday 15 February 2016 09:19 PM, Nishanth Menon wrote: > On 02/14/2016 10:27 PM, Keerthy wrote: >> >> >> On Saturday 13 February 2016 04:11 AM, Tony Lindgren wrote: >>> * Nishanth Menon <nm@ti.com> [160212 14:32]: >>>> On Fri, Feb 12, 2016 at 4:23 PM, Tony Lindgren <tony@atomide.com> wrote: >>>>> * Nishanth Menon <nm@ti.com> [160209 14:17]: >>>>>> On 02/09/2016 04:09 PM, Eduardo Valentin wrote: >>>>>>> On Mon, Feb 08, 2016 at 03:15:05PM +0530, Keerthy wrote: >>>>>>>> The thermal threholds for am57xx are different from that of dra7. >>>>>>>> Correcting the thresholds for the same. >>>>>>>> >>>>>>>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>>>>>>> --- >>>>>>>> >>>>>>>> Depends on: https://lkml.org/lkml/2016/2/8/90 >>>>>>>> >>>>>>>> arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++ >>>>>>>> 1 file changed, 24 insertions(+) >>>>>>>> >>>>>>>> Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts >>>>>>>> =================================================================== >>>>>>>> --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.514959101 +0530 >>>>>>>> +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.510959168 +0530 >>>>>>> >>>>>>> Sorry, did not bother to check, but is this the only user of am57xx? >>>>>> >>>>>> we will have AM57xx-IDK as well coming down the line. we already have >>>>>> arch/arm/boot/dts/am57xx-cl-som-am57x.dts >>>>>> arch/arm/boot/dts/am57xx-sbc-am57x.dts - not really sure what grade of >>>>>> silicon are used in cl-SOM and sbc boards. >>>>> >>>>> Hmm can this one wait for v4.6 or is it critical for v4.5-rc >>>>> cycle? >>>> >>>> personally, I'd like to NAK this patch -> lack of reference >>>> documentation, and guidance for various AM57xx boards in a generic >>>> patch should probably be followed IMHO. >>> >>> OK let's wait for that then. >> >> OK. I will send a v2 with better documentation. > > > > This data is in the AM572x datasheet: > http://www.ti.com/lit/ds/symlink/am5728.pdf > > Table 5-3 in the current version contains the maximum junction > temperatures. > > this indicates that there are "Commercial" and "extended" -> we may > need to introduce just 2 dtsis -> am57xx-commercial and > am57xx-extended and reuse those based on the part on the board. just a > suggestion.. Or use the minimum of the 2 to be on the safer side if we have to deal with one dtsi? Regards, Keerthy > >
On 02/15/2016 10:13 AM, Keerthy wrote: [...] >> >> This data is in the AM572x datasheet: >> http://www.ti.com/lit/ds/symlink/am5728.pdf >> >> Table 5-3 in the current version contains the maximum junction >> temperatures. >> >> this indicates that there are "Commercial" and "extended" -> we may >> need to introduce just 2 dtsis -> am57xx-commercial and >> am57xx-extended and reuse those based on the part on the board. just a >> suggestion.. > > Or use the minimum of the 2 to be on the safer side if we have to deal > with one dtsi? Why would we want to throttle earlier on customer platforms or other boards using extended? at the very least -> if all upstream boards have only commercial grade, then just introduce am57xx-commercial-thermal.dtsi ..
Index: linux/arch/arm/boot/dts/am57xx-beagle-x15.dts =================================================================== --- linux.orig/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.514959101 +0530 +++ linux/arch/arm/boot/dts/am57xx-beagle-x15.dts 2016-02-08 14:57:05.510959168 +0530 @@ -825,3 +825,27 @@ status = "okay"; }; }; + +&cpu_alert0 { + temperature = <90000>; /* milliCelsius */ +}; + +&cpu_crit { + temperature = <105000>; /* milliCelsius */ +}; + +&gpu_crit { + temperature = <105000>; /* milliCelsius */ +}; + +&core_crit { + temperature = <105000>; /* milliCelsius */ +}; + +&dspeve_crit { + temperature = <105000>; /* milliCelsius */ +}; + +&iva_crit { + temperature = <105000>; /* milliCelsius */ +};
The thermal threholds for am57xx are different from that of dra7. Correcting the thresholds for the same. Signed-off-by: Keerthy <j-keerthy@ti.com> --- Depends on: https://lkml.org/lkml/2016/2/8/90 arch/arm/boot/dts/am57xx-beagle-x15.dts | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)