| Message ID | 1455199485-24458-1-git-send-email-s.trumtrar@pengutronix.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
On Thu, Feb 11, 2016 at 03:04:43PM +0100, Steffen Trumtrar wrote: > Add documentation for the Freescale Security Controller (SCC) > found on i.MX25 SoCs. > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > --- > .../devicetree/bindings/crypto/fsl-imx-scc.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 11, 2016 at 03:04:43PM +0100, Steffen Trumtrar wrote: > Add documentation for the Freescale Security Controller (SCC) > found on i.MX25 SoCs. > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > --- > .../devicetree/bindings/crypto/fsl-imx-scc.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt > > diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt b/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt > new file mode 100644 > index 000000000000..9a15ab8da94f > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt > @@ -0,0 +1,17 @@ > +Freescale Security Controller (SCC) > + > +Required properties: > +- compatible : Should be "fsl,imx25-scc". > +- reg : Should contain register location and length. > +- interrupts : Should contain interrupt numbers for SCM IRQ and SMN IRQ. > + > +Example: > + > + scc: crypto@53fac000 { > + compatible = "fsl,imx25-scc"; > + reg = <0x53fac000 0x4000>; > + clocks = <&clks 111>; > + clock-names = "ipg"; Shouldn't these two be mentioned in properties list above too? Shawn > + interrupts = <49>, <50>; > + interrupt-names = "scm", "smn"; > + }; > -- > 2.7.0.rc3 > > -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi! Shawn Guo writes: > On Thu, Feb 11, 2016 at 03:04:43PM +0100, Steffen Trumtrar wrote: >> Add documentation for the Freescale Security Controller (SCC) >> found on i.MX25 SoCs. >> >> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> >> --- >> .../devicetree/bindings/crypto/fsl-imx-scc.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt >> >> diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt b/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt >> new file mode 100644 >> index 000000000000..9a15ab8da94f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt >> @@ -0,0 +1,17 @@ >> +Freescale Security Controller (SCC) >> + >> +Required properties: >> +- compatible : Should be "fsl,imx25-scc". >> +- reg : Should contain register location and length. >> +- interrupts : Should contain interrupt numbers for SCM IRQ and SMN IRQ. >> + >> +Example: >> + >> + scc: crypto@53fac000 { >> + compatible = "fsl,imx25-scc"; >> + reg = <0x53fac000 0x4000>; >> + clocks = <&clks 111>; >> + clock-names = "ipg"; > > Shouldn't these two be mentioned in properties list above too? > What is the current policy on clocks in bindings? There are some with and some without. Of course I can add them to the required properties if necessary. Thanks, Steffen
On Tue, Feb 16, 2016 at 09:41:17AM +0100, Steffen Trumtrar wrote: > > Hi! > > Shawn Guo writes: > > > On Thu, Feb 11, 2016 at 03:04:43PM +0100, Steffen Trumtrar wrote: > >> Add documentation for the Freescale Security Controller (SCC) > >> found on i.MX25 SoCs. > >> > >> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > >> --- > >> .../devicetree/bindings/crypto/fsl-imx-scc.txt | 17 +++++++++++++++++ > >> 1 file changed, 17 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt > >> > >> diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt b/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt > >> new file mode 100644 > >> index 000000000000..9a15ab8da94f > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt > >> @@ -0,0 +1,17 @@ > >> +Freescale Security Controller (SCC) > >> + > >> +Required properties: > >> +- compatible : Should be "fsl,imx25-scc". > >> +- reg : Should contain register location and length. > >> +- interrupts : Should contain interrupt numbers for SCM IRQ and SMN IRQ. > >> + > >> +Example: > >> + > >> + scc: crypto@53fac000 { > >> + compatible = "fsl,imx25-scc"; > >> + reg = <0x53fac000 0x4000>; > >> + clocks = <&clks 111>; > >> + clock-names = "ipg"; > > > > Shouldn't these two be mentioned in properties list above too? > > > > What is the current policy on clocks in bindings? There are some with > and some without. > > Of course I can add them to the required properties if necessary. I think any required properties should be listed in "Required properties:" section. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt b/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt new file mode 100644 index 000000000000..9a15ab8da94f --- /dev/null +++ b/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt @@ -0,0 +1,17 @@ +Freescale Security Controller (SCC) + +Required properties: +- compatible : Should be "fsl,imx25-scc". +- reg : Should contain register location and length. +- interrupts : Should contain interrupt numbers for SCM IRQ and SMN IRQ. + +Example: + + scc: crypto@53fac000 { + compatible = "fsl,imx25-scc"; + reg = <0x53fac000 0x4000>; + clocks = <&clks 111>; + clock-names = "ipg"; + interrupts = <49>, <50>; + interrupt-names = "scm", "smn"; + };
Add documentation for the Freescale Security Controller (SCC) found on i.MX25 SoCs. Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> --- .../devicetree/bindings/crypto/fsl-imx-scc.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt