Message ID | 20110328082305.c6fa41d9.randy.dunlap@oracle.com (mailing list archive) |
---|---|
State | Accepted |
Headers | show |
Em 28-03-2011 12:23, Randy Dunlap escreveu: > From: Randy Dunlap <randy.dunlap@oracle.com> > > altera-jtag.c needs to include <linux/delay.h> to fix a build error: > > drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay' > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> > Cc: Igor M. Liplianin <liplianin@netup.ru> > --- > drivers/staging/altera-stapl/altera-jtag.c | 1 + > 1 file changed, 1 insertion(+) > > Somehow I was supposed to know to send this to Mauro instead of to Greg, > but I don't see anything in drivers/staging/altera-stapl/ that says that. Ah, yes, we need to add a readme file there stating about that. Greg, you may add it on your tree, or if you prefer, I can just add here for my next upstream pull. Thanks, Mauro. > > > --- linux-next-20110304.orig/drivers/staging/altera-stapl/altera-jtag.c > +++ linux-next-20110304/drivers/staging/altera-stapl/altera-jtag.c > @@ -23,6 +23,7 @@ > * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > */ > > +#include <linux/delay.h> > #include <linux/firmware.h> > #include <linux/slab.h> > #include <staging/altera.h> > -- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 19, 2011 at 04:22:06PM -0300, Mauro Carvalho Chehab wrote: > Em 28-03-2011 12:23, Randy Dunlap escreveu: > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > altera-jtag.c needs to include <linux/delay.h> to fix a build error: > > > > drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay' > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> > > > Cc: Igor M. Liplianin <liplianin@netup.ru> > > --- > > drivers/staging/altera-stapl/altera-jtag.c | 1 + > > 1 file changed, 1 insertion(+) > > > > Somehow I was supposed to know to send this to Mauro instead of to Greg, > > but I don't see anything in drivers/staging/altera-stapl/ that says that. > > Ah, yes, we need to add a readme file there stating about that. > > Greg, you may add it on your tree, or if you prefer, I can just add here for > my next upstream pull. I see this in my tree already, git commit 92ce52695ccf2b6c4ef7eb02e1bee1bcbf5fde89, what happened to need this again? confused, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/19/11 13:39, Greg KH wrote: > On Thu, May 19, 2011 at 04:22:06PM -0300, Mauro Carvalho Chehab wrote: >> Em 28-03-2011 12:23, Randy Dunlap escreveu: >>> From: Randy Dunlap <randy.dunlap@oracle.com> >>> >>> altera-jtag.c needs to include <linux/delay.h> to fix a build error: >>> >>> drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay' >>> >>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> >> >>> Cc: Igor M. Liplianin <liplianin@netup.ru> >>> --- >>> drivers/staging/altera-stapl/altera-jtag.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> Somehow I was supposed to know to send this to Mauro instead of to Greg, >>> but I don't see anything in drivers/staging/altera-stapl/ that says that. >> >> Ah, yes, we need to add a readme file there stating about that. >> >> Greg, you may add it on your tree, or if you prefer, I can just add here for >> my next upstream pull. > > I see this in my tree already, git commit > 92ce52695ccf2b6c4ef7eb02e1bee1bcbf5fde89, what happened to need this > again? I think that Mauro is just replying to old emails (guess he's just trying to catch up...).
--- linux-next-20110304.orig/drivers/staging/altera-stapl/altera-jtag.c +++ linux-next-20110304/drivers/staging/altera-stapl/altera-jtag.c @@ -23,6 +23,7 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ +#include <linux/delay.h> #include <linux/firmware.h> #include <linux/slab.h> #include <staging/altera.h>