| Message ID | 20160217110441.GA21406@lkp-sb04 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Feb 17, 2016 at 07:04:41PM +0800, kbuild test robot wrote: > fs/btrfs/volumes.c:1886:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Anand Jain <anand.jain@oracle.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Thanks, applied to the respective branch. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1882,8 +1882,7 @@ int btrfs_rm_device(struct btrfs_root *r } out: - if (dev_name) - kfree(dev_name); + kfree(dev_name); mutex_unlock(&uuid_mutex); return ret;
fs/btrfs/volumes.c:1886:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Anand Jain <anand.jain@oracle.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- volumes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html